Materialverter

Used the materialverter for the first time today, from Sheetcam. Everything worked great, except for one small detail, I had the Cut Mode set as 2 for all of my materials, and it didn't pick that up, they were all at Cut Mode = 1 after the conversion. So, I proposed the fix on github. Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems... I'm proposing solutions . :woohoo:

Just in case you want any code to test the fix (it works on my end)...

Input Example:
Output Example (before fix):
Output Example (after fix):
First HAL, now Github changes... wonder what's next!?

EDIT: I am 99% sure I proposed the changes correctly on github. If I didnt, and I need to do it some other way, please let me know. Also, if you prefer I suggest changes here instead, let me know that as well.

snowgoer540 wrote: Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems...

You need to stop that, your making the rest of us look bad

thefabricator03 wrote:

snowgoer540 wrote: Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems...

You need to stop that, your making the rest of us look bad

Haha, well hopefully it's not a 1 hit wonder.

Thanks for that, something else I missed.

A couple of additions are required to bring the version number up to date:

in the same directory:
plasmac_config.py - line 324 - new version and date
version.html - line 22 - create a new version and date block

in linuxcnc-dev/src/hal/components:
plasmac.comp - line 10 - new version and date

Maybe I should put a sticky thread describing this in case others want to contribute code.

phillc54 wrote: Thanks for that, something else I missed.

A couple of additions are required to bring the version number up to date:

in the same directory:
plasmac_config.py - line 324 - new version and date
version.html - line 22 - create a new version and date block

in linuxcnc-dev/src/hal/components:
plasmac.comp - line 10 - new version and date

Maybe I should put a sticky thread describing this in case others want to contribute code.

Well, on the bright side, something you dont have to spend time fixing In all reality, I just plagiarized what was there, and changed variable names. I couldnt write that code outright.

Ok, other than the additions to the files, did I do everything else correctly? Am I supposed to start a pull request to linuxcnc? I'm a bitt miffed about how it actually gets into the next update...

Do you want me to make the aforementioned changes to the other 3 files?

snowgoer540 wrote: Well, on the bright side, something you dont have to spend time fixing In all reality, I just plagiarized what was there, and changed variable names. I couldnt write that code outright.

Well you found where the problem was and that is half the battle.

Ok, other than the additions to the files, did I do everything else correctly? Am I supposed to start a pull request to linuxcnc? I'm a bitt miffed about how it actually gets into the next update...

Yeah, you can do it that way, it is a good way to contribute. The PR's get manually merged by whoever thinks they should be merged.

Do you want me to make the aforementioned changes to the other 3 files?

Yeah, if you want to complete the commit and get it merged.

phillc54 wrote: Yeah, if you want to complete the commit and get it merged.

Do I have to do these as separate pull requests?

No, keep it all under the one PR

phillc54 wrote: No, keep it all under the one PR

perhaps a stupid question, but how do I add file changes to the PR I already started?

If you commit work and then push to the branch you created if will keep if on the same PR

This is from your PR page: github.com/LinuxCNC/linuxcnc/pull/899
"Add more commits by pushing to the patch-1 branch on snowgoer540/linuxcnc"