Problems with Vista CNC pendent

After upgrading to 2.9 (because I have to), I discovered that I can't get my spindle to operate. Not only does the pendent not work for that function, but G3 from the manual input line has no effect. The hal file for my mill is called xyz.hal and includes this line:

xyz.hal:net spindle-on      => parport.0.pin-01-out

And the pendent hal includes the following:vc-p4s.hal:net spindle.is-on halui.spindle.0.is-on =>  vc-p4s.spindle.is-on =11pt 

I changed xyz.hal to replace "spindle-on" with "spindle.is-on" and now both the pendant and G3/G5 work as expected. Is that the correct fix or is the vista code wrong?

  

Spindle are M codes

Sorry, M3/M5. But same question.

Technically if you are trying to match to the vc-ps.hal, your xyz.hal was wrong. On the other hand if you are trying to match your xyz.hal, the vc-ps.hal was wrong.

As long as the signals are the same name you're good to go.

You could have had. And
But it kind of looks silly and hard to read later on.

This will give you a better idea.
linuxcnc.org/docs/master/html/hal/intro.html

the xyz.hal was generated, from scratch by stepconf. It seems really odd that linuxcnc wouldn't be able to operate the spindle using the hal file generated by its own tool. But, its been an odd week.

It's more likely whoever created the vista hal file. Was the vista hal file the one from the vistaCNC site ?

I think its a bug. I just created a second configuration, using stepconf from scratch (no import) without adding the vistaCNC driver code. It does the same thing. The keyboard can jog the table, but the spindle does not respond to g-code.

Well if you think you have found a bug raise an issue on the github page.

In saying that you will need to provide more info. At the very least the gui you are using.

How are you formatting the M code to turn on the spindle ?

Usually in a case like this it is common practice to attach the hal & ini files.

Subscribed..... As I have a Vista pendant also.