documents hyperlinks

More
5 years 6 months ago #204813 by robertspark
Replied by robertspark on topic documents hyperlinks
<><> answered my own questions

Please Log in to join the conversation.

More
5 years 6 months ago #204862 by robertspark
Replied by robertspark on topic documents hyperlinks
how does one get a change considered or approved?

do I have to do something specific, or assign it to someone specific?

github.com/LinuxCNC/linuxcnc/pull/1122

Please Log in to join the conversation.

More
5 years 6 months ago #204863 by HansU
Replied by HansU on topic documents hyperlinks
Thanks for your contribution!

Code:
do I have to do something specific, or assign it to someone specific?
No, you only have to wait if someone have a look at it and decide to merge it.

Does it have a specific reason why you left out links on some components?

Hans

Please Log in to join the conversation.

More
5 years 6 months ago #204866 by robertspark
Replied by robertspark on topic documents hyperlinks
I just had not finished.

I thought I'd try to commit something to see the process and also see if it will be integrated (no point in wasting time in doing something if there is no interest in integrating it)

I then carried on working, found a couple of minor things, and added a number of user components to the list along with their links.

finished for the evening, and saved my changes and pushed the 2nd commit.

again I wanted to see if my changes would be accepted as I don't want to waste a load of time doing something if there is no interest to incorporate.

once done, I'll look at translating the components.txt to French and Spanish to update those two files too.

(I have also noticed a few inconsistencies with some of the man files (titles, descriptions etc), but thought I'd finish with the one file first before looking as other stuff.....

“there is only one way to eat an elephant: a bite at a time.” Desmond Tutu

Please Log in to join the conversation.

More
5 years 6 months ago #204873 by robertspark
Replied by robertspark on topic documents hyperlinks
wiki.linuxcnc.org/cgi-bin/wiki.pl?BeyondWikiToo

what version of asciidocs does lcnc presently run (I ask because the wiki is obviously old, but seems to have a fair bit of info more than the general html docs on documentation)

thanks

answered own question (headslap!)

packages.debian.org/search?keywords=asciidoc :silly: :woohoo:

Please Log in to join the conversation.

More
5 years 6 months ago #204878 by rodw
Replied by rodw on topic documents hyperlinks
Robert, I'd get on the mailing list and maybe the chat channel and ask people to review and accept your changes.

Please Log in to join the conversation.

More
5 years 6 months ago #204879 by robertspark
Replied by robertspark on topic documents hyperlinks

rodw wrote: Robert, I'd get on the mailing list and maybe the chat channel and ask people to review and accept your changes.


thanks Rod,

I got on all three lists this morning

but the emc commit list stated:

Welcome to the Emc-commit@lists.sourceforge.net mailing list! Note
that you should _NOT_ send mail directly to the list. Github will do
so on your behalf when you make commits


but my commits don't seem to be listed on the list.... maybe I need to set something up on my git repository.

Please Log in to join the conversation.

More
5 years 6 months ago #204884 by rodw
Replied by rodw on topic documents hyperlinks
Yes I can see your pull request in the list here
github.com/LinuxCNC/linuxcnc/pulls

Good luck

Please Log in to join the conversation.

More
5 years 6 months ago #204888 by phillc54
Replied by phillc54 on topic documents hyperlinks

robertspark wrote: but my commits don't seem to be listed on the list.... maybe I need to set something up on my git repository.

I received a list email this morning about your PR

Please Log in to join the conversation.

More
5 years 6 months ago #204891 by robertspark
Replied by robertspark on topic documents hyperlinks
thanks,

I know that I've at least done all I can for the moment, subject to review.

(all about understanding the process, and getting it right)

Please Log in to join the conversation.

Time to create page: 0.230 seconds
Powered by Kunena Forum