Hello,
Few people know that the command self.command.wait_complete() has a time limit that can be set and the default value is 5seconds.
Code:
self.command.wait_complete()
self.command.mode(linuxcnc.MODE_MDI)
self.command.wait_complete()
self.command.mdi("G91 G1 X10 F200")
self.command.wait_complete(2)
self.command.mdi("G91 G1 Y10 F200")
self.command.wait_complete()
self.command.mode(linuxcnc.MODE_MANUAL)
self.command.wait_complete()
The problem is that if this limit is exceeded, the source code continues and there is no warning.
I was able to create two kinds of warnings.
1) silent warning with fprintf. If the time limit is exceeded, the source code continues, but at least an error note appears in the terminal.
Attachment not found
2) drastically stop the code with PyErr_Format
Attachment not found
I would like to make a Pull Request, but I don't know which option to choose. Can any of you think of another option?
github.com/LinuxCNC/linuxcnc/blob/master...ns/emcmodule.cc#L213
Code:
static int emcWaitCommandComplete(pyCommandChannel *s, double timeout) {
double start = etime();
do {
double now = etime();
if(s->s->peek() == EMC_STAT_TYPE) {
EMC_STAT *stat = (EMC_STAT*)s->s->get_address();
int serial_diff = stat->echo_serial_number - s->serial;
if (serial_diff > 0) {
return RCS_DONE;
}
if (serial_diff == 0 &&
( stat->status == RCS_DONE || stat->status == RCS_ERROR )) {
return stat->status;
}
}
esleep(fmin(timeout - (now - start), EMC_COMMAND_DELAY));
} while (etime() - start < timeout);
PyErr_Format( error, "Python WaitCommandComplete timed out");
//fprintf(stderr,"Error - Python WaitCommandComplete timed out \n");
return -1; [attachment=60361]fprintf.png[/attachment]
