Question on recent SPINDLE_9 change

I am testing pncconf off of 2.8 and master, and I believe this recent change introduces a regression:

github.com/LinuxCNC/linuxcnc/commit/2ae2...b09b9dbd111acd4b282c

specifically, there is a mismatch in the generated configuration between SPINDLE_9 and SPINDLE_0 between the hal and ini files.

In build_INI.py there is the following line 299:

and line 320:

and in build_HAL.py there is (line 401):

I'm willing to work on a fix for this, but I am wondering what the desired behavior is. Is multi-spindle a consideration here?

Thanks!

Scott

Sorry to hijack your thread but...

If you are looking at spindle handling by PncConf it would be nice if there was an option to have no spindle configuation done by PncConf.

Yes - oops...i did it again.
My intention was to switch to use spindle_0 as in 2.8 there is actually multiple spindle allowed. The original 9 was a shortcut of using the axie functions to write the spindle (there are 0-8 axes and so spindle was 9)

Phill it should be easy to add a checkbox on the 'base information' page.
I wonder if I can get that wrong too

Chris

I wonder if I can get that wrong too

I have a knack for that as well. :ohmy:

Chris- I am sure it will only take you a minute to fix, but if you want me to propose a fix for the SPINDLE_9 issue, now that I understand your intention I'm happy to do that, just let me know.

Thanks!

Scott

I'll fix it thanks though.
See my comment on your last pull request- thanks for the code!