If servo period is changed the coresponding P values for PID do not change

Noticed this lately, if servo period is set to say 2000000 the P values will remain at 1000 (should be 500), and that causes issues where the steppers run rough or joint errors occur often.
How much trouble would it be to add the feature to calculate the P values for servo period entered?

The 'pncconf' configuration tool does this automatically.

If you want to check the `P` values in the ini file against the `SERVO_PERIOD` then this might be something that a GUI could do on start up followed by a message pop up in the GUI.

Aciera wrote:

The 'pncconf' configuration tool does this automatically.

Nope, it does not when editing an existing config for sure, did not check when creating a new one.
This was on 2.10 or master.

Definitely works when creating a new config (tested on 2.9.10 and master) .

[edit]
It does not work when editing an existing config.

Thank you Aciera, i do not use wizards as i am used to manually editing everything, but been forcing myself to use them lately.

I've had a look and we could generate a popup when the servo period has been changed in an existing config:

 

PR is here:  github.com/LinuxCNC/linuxcnc/pull/4263

Nice, thank you.