Framing set origen

Framing turns the laser on, but it is not on the path that corresponds to the actual cut.

I messed with this a bit after work (using a pencil as my laser haha).  I think I do see the issue.  I will try to see if I can fix it.

Thanks lol I think the framing should not use the offsets (x and y) it just follows the framing of the current G code.

the intent is when you have a laser, it will frame with the laser.  

it's a sign issue in the code.  It will be fixed soon

Ok Thanks luckily you could understand me

Should be fixed, I pushed a commit for Phill to approve. If approved you'll just have to wait for the buildbot to do its thing, and update later.

Before:


After:

thanks that looks good.

To me that does not look right. Setting up Framing is next on my plasma agenda.
Say you have a job that starts at the origin 0,0 and your laser offsets are 50mm, 50mm (or 2 x 2 dinosaurs)
You move the laser to  the 0,0 position you want to use and touch off with the laser. The offsets are changed but plasmac does not move the torch to the 0,0 position (which is how I did it in Gmoccappy) So if the framing is now based on the torch position, you would have to issue a G0 X0 Y0 before framing for it to track the job.

I think the laser touchoff should move the torch to the new 0,0 position for this method to be accurate.

Wait until I test before panicking.

rodw wrote:

So if the framing is now based on the torch position, you would have to issue a G0 X0 Y0 before framing for it to track the job.

Was thinking the same thing since this topic started, but since i do not use the feature, i kept my mouth shut!

Rodw did all that but it did not work after placing my origin I smashed the x0y0 button but it does not solve the problem, now I tried the recent update and it is working as it should.