probe basic notification dialogues

hello,

I created a branch for python2 but I cant test it

dialogs_fix_py2

@0ddbod I just tried the branch and it works perfectly! thanks for the info!!

No problem at all, will speak with @TurBoss to get this merged to master so everybody can have it
Thanks for testing  

python3 fixes went master

thanks

Thanks for the fix, but I'm not sure how to incorporate it. I see that the fix was in native_notification.py - I was hopeful that I could find this file and port the changes over. After not being able to find the file, I tried to do an update through the probe basic installer with a new repo location of github.com/kcjengr/qtpyvcp/tree/dialogs_fix_py2 , but without an update.xml that won't work. 

Is there is a document I could check out that would help?

Hello tightmopedman9

to get the fixes you may need a git setup

mkdir somedir/
cd somedir/
git clone github.com/kcjengr/qtpyvcp/
cd qtpyvcp/
git switch dialogs_fix_py2

pip install -e .
qcompile -e .

cd ../

git clone github.com/kcjengr/qtpyvcp.conversational-gcode/

cd qtpyvcp.conversational-gcode/

pip install -e .
qcompile -e .

cd ../

git clone github.com/kcjengr/probe_basic/

cd probe_basic/
pip install -e .
qcompile -e .


but if you can wait I'm just installing debian 10 + 2.8 in a virtual machine to test


Thanks

Maybe so.
 
.

You need to do it properly via git and you have 3 methods:

Made it as far as 'qcomplie -e .', but I'm hitting a 'qcompile: command not found' error now. Fixed by executing the command as sudo and omitting the '-e'. 

dialogs fix for 2.8 installed. Testing now.

Generated about 100 errors and all of them were in the correct location, so the fix appears to have worked. Thanks!