Couldn't get the WARNING icon in LcncDialog

Hi, I had a little trouble displaying the warning icon in a LcncDialog widget. I think it's caused by setting the default to INFO icon before checking WARNING and CRITICAL (dialog_widget.py in master 0fda49f):


Changing the sequence of the statements lets me choose also the WARNING icon.
Sorry, have some problems formatting the code passage in my message

It might be helpful to know how you are calling it?

Yes, I call it by connecting STATUS 'general' message and the ACTION.CALL_DIALOG:

A LcncDialog widget with matching launch-ID is defined in the ui-file. I have already checked whether the value of the 'icon'-variable is set correctly right before the statement I have shown in my first post (first code box). It's all fine. Looking at the original code, I think, because 'icon' is an instance of string in all cases, the 'WARNING' and 'CRITICAL' cases can never be reached. So I changed the sequence in order to give WARNING and CRITICAL also a chance getting active. Am I right with my consideration or have i missed something?

I made a few minutes to take a look at this tonight.  

I do see the behavior you describe, although the order is not the root cause. 

In this line:  github.com/LinuxCNC/linuxcnc/blob/bd9034...ialog_widget.py#L201



it's this part that is causing issue:



The icon value is set correctly to 'WARNING' on the go-in, but because but because icon is of type str, the second condition "isinstance(icon, str)" evaluates to True, and therefore never gets to check for 'WARNING'.

Perhaps it’s meant to be a catch all, in that case I agree it should move to last, but I want Chris to weigh in before I change it as I'm not quite sure of the purpose (if typo should we tell the user there’s a typo?).

Yes its a catchall that should be at the end.
I think I added warning and critical after the others and didn't think of the logic.
Good eye gents!

Fixed! Thanks for the bug report!

github.com/LinuxCNC/linuxcnc/commit/d359...3acf64a5cabe4665e5d3