Schmitt trigger

More
6 years 11 months ago #151335 by csbrady
Replied by csbrady on topic Schmitt trigger
After dealing with bobble with analog overrides and erratic spindle speed displays I created a hal component to filter, add hysteresis and do rounding. The results are excellent! I set my analog feed override to provide nice crisp 5% increments. Also my spindle speed bounces around making it difficult to read. Now the display shows nice 50 rpm steps. All very stable with no bobble.

If interested the source with a makefile and a hal sample is available at bradyz.com/hyst.tgz
The following user(s) said Thank You: thadwald, roland

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #151372 by andypugh
Replied by andypugh on topic Schmitt trigger
Do you want to add it to LinuxCNC?

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #151374 by csbrady
Replied by csbrady on topic Schmitt trigger
Yes it I would like to add it to LinuxCNC. I suspect that others would find it helpful.

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #151375 by andypugh
Replied by andypugh on topic Schmitt trigger
Are you able to submit a pull-request on github? (There are other ways, but that way is least likely to get lost). Just adding the .comp file in the src/hal/components directory will be enough, the build system will then compile it automatically. A standalone .comp should be safe for 2.8

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #151398 by csbrady
Replied by csbrady on topic Schmitt trigger
Sorry but I don't know what a pull-request is. Can you give me some guidance?

Please Log in or Create an account to join the conversation.

More
6 years 11 months ago #151552 by andypugh
Replied by andypugh on topic Schmitt trigger

csbrady wrote: Sorry but I don't know what a pull-request is. Can you give me some guidance?


There is a guide here: guides.github.com/activities/hello-world/
Though it isn't 100% relevant to your situation.

You would need to create a githib account, make a fork of linuxCNC, add your file, make a commit and then make a pull request.

If you think that you might get in to the habit of working on LinuxCNC then it is worth doing all that. If this is a one-off then it is probably easier for one of us to add the .comp file by hand. Though I don't think that you get a "credit" for the work that way.

Please Log in or Create an account to join the conversation.

Time to create page: 0.062 seconds
Powered by Kunena Forum