Minor typo in Pncconf...

More
02 May 2023 03:04 #270444 by Geosec
POSITIVE TRAVEL DISTANCEThis is the distance the Axis travels from the Origin to the positive travel distance or the total travel minus the negative travel distance. You would set this to zero if the origin is positioned at the positive limit. The will always be zero or a positive number.
Probably should be:POSITIVE TRAVEL DISTANCEThis is the distance the Axis travels from the Origin to the positive travel distance or the total travel minus the negative travel distance. You would set this to zero if the origin is positioned at the positive limit. This will always be zero or a positive number
Regarding typos in the documentation, where's the best place to report them? Or should I even bother for such minor stuff?

 

Please Log in or Create an account to join the conversation.

More
02 May 2023 03:34 #270446 by phillc54
Replied by phillc54 on topic Minor typo in Pncconf...
A couple of options:

You could create an issue on GitHub.
github.com/LinuxCNC/linuxcnc/issues

You could create a GitHub account and directly edit the file by clicking the edit icon (a pencil) at the top of the text, this will create a pull request and a developer will then check the changes before committing.
github.com/LinuxCNC/linuxcnc/blob/master.../help-axisconfig.txt

Please Log in or Create an account to join the conversation.

More
02 May 2023 10:13 #270467 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Perfect. Thanks for the education.

I'll see about the GitHub account to try to be more proactive. I hate to bother busy folks with such minor issues.
The following user(s) said Thank You: phillc54

Please Log in or Create an account to join the conversation.

More
02 May 2023 10:44 #270469 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
I like that approach.
A pull request has been created.
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
02 May 2023 13:12 #270479 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
I found another typo that I was going to open a pull request for, but I can't figure out how to get to the text on GitHub to initiate the request.
Can someone point me to some info on how to navigate GitHub LinuxCNC please.

The text is in section 2. Create or Edit...
If you made any changes to the main hal or ini files Pncconf will over write those files...

If you made any changes to the main hal or ini files Pncconf will overwrite those files...

Please Log in or Create an account to join the conversation.

More
03 May 2023 15:28 #270573 by HansU
Replied by HansU on topic Minor typo in Pncconf...
Wasn't that you who created the other pull request?

Please Log in or Create an account to join the conversation.

More
03 May 2023 15:52 #270574 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Yes, but moderator phillc54 provided a link that took me right to where I needed to be to create the pull request, which is only that one section of the document. I went back through the directory tree a bit but couldn't find the section mentioned above. Create or edit.
I looked at some info on how to create pull requests on the 'net but they seemed really involved... cloning, downloading, editing, uploading, etc. Seemed crazy complicated just to remove an extra space between two words.
 

Please Log in or Create an account to join the conversation.

More
03 May 2023 16:04 #270575 by HansU
Replied by HansU on topic Minor typo in Pncconf...
So you only didn't find the file?

Here it is: github.com/LinuxCNC/linuxcnc/blob/2.9/do.../config/pncconf.adoc

Please Log in or Create an account to join the conversation.

More
03 May 2023 16:10 #270576 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Correct. Thanks!
How do I go about finding things like this on my own on GitHub? Is there a guide to the structure/directory tree, or does it just come with experience?
I never would have found that.

Please Log in or Create an account to join the conversation.

More
03 May 2023 16:13 #270577 by HansU
Replied by HansU on topic Minor typo in Pncconf...
Just full text search in my local clone ;-)
The following user(s) said Thank You: Geosec

Please Log in or Create an account to join the conversation.

Moderators: HansU
Time to create page: 0.171 seconds
Powered by Kunena Forum