G33.1 synchronized tapping problem

I finally got my butt in gear and sorted out the new spindle motor and LCNC config using @Aciera's template.

I can confirm a few things:

• His configuration works for me
  • Single motor for spindle/orient/c-axis using step/dir drive.
  • Mode changes using encoder-disconnect component in config template
  • Orient using his s-orient component
• The G33.1 problem exists as he describes (clearly) in the github post.
  • Instant Z-negative rapid at start of G33.1 move
  • Magnitude of rapid move is dependent on how far from the index signal the spindle is when the program starts.
• The workaround (disconnect joint.N.index-enable in spindle/orient mode) works.

I've responded on github here:
github.com/LinuxCNC/linuxcnc/issues/3556

@Aciera - Thank you VERY much for looking in to this.

I think I might have the fix
github.com/LinuxCNC/linuxcnc/pull/4200

@grandixximo -

That would be a huge win if your fix works.

Now, if you can figure out the non-deterministic threading/tapping...

github.com/LinuxCNC/linuxcnc/issues/3455

Yes! that is a win, especially if combined with the new G28 that allows rehoming
a single axis. That would really simplify combined axis/spindle operations.

had a stab at #3455 as well github.com/LinuxCNC/linuxcnc/pull/4453
also check
github.com/LinuxCNC/linuxcnc/pull/4441