- Posts: 731
- Thank you received: 0
Translate offsetpage.glade.h - dont work
4 years 3 months ago #248419
by HansU
Replied by HansU on topic Translate offsetpage.glade.h - dont work
So this thread can be seen as resolved, right?
Please Log in to join the conversation.
4 years 3 months ago #248460
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
I made
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/cs.po file
from linuxcnc.pot
I found, that it duplicate
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/gmoccapy/cs.po file
Is this duplication intentional?
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/cs.po file
from linuxcnc.pot
I found, that it duplicate
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/gmoccapy/cs.po file
Attachment not found
Is this duplication intentional?
Please Log in to join the conversation.
4 years 3 months ago #248464
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
I have another problem.
My src/po/cs.po file is not same as your src/po/cs.po file.
My src/po/cs.po file dont contains
"Comments" or "Offset Name"
Could you please remove your linuxcnc.pot , rebuild LCNC and check it?
My src/po/cs.po file is not same as your src/po/cs.po file.
My src/po/cs.po file dont contains
"Comments" or "Offset Name"
Could you please remove your linuxcnc.pot , rebuild LCNC and check it?
Please Log in to join the conversation.
4 years 3 months ago #248470
by HansU
Replied by HansU on topic Translate offsetpage.glade.h - dont work
What do you mean with this? These two cs.po files should be completely different. One derived from gmoccapy.pot, the other from linuxcnc.potI found, that it duplicate
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/gmoccapy/cs.po file
But it should. Look into linuxcnc.pot, it does contain these strings.My src/po/cs.po file dont contains
"Comments" or "Offset Name"
Please Log in to join the conversation.
4 years 3 months ago #248471
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
I agree with what you write. My error looks like the tool that generates the linuxcnc.pot file went wrong.
In my linuxcnc.pot file is merged gmoccapy.pot file.
Are you working on branch 2.8?
In my linuxcnc.pot file is merged gmoccapy.pot file.
I made /src/po/cs.po file from linuxcnc.potBut it should. Look into linuxcnc.pot, it does contain these strings.
Are you working on branch 2.8?
Please Log in to join the conversation.
4 years 3 months ago #248510
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
You probably use branch 2.9
linuxcnc.pot 2.9 contains
"Comments" or "Offset Name"
doesnt have duplicate strings with gmoccapy.pot
linuxcnc.pot 2.8 or 2.8.2 doesnt contains
"Comments" or "Offset Name"
have duplicate strings with gmoccapy.pot
linuxcnc.pot 2.9 contains
"Comments" or "Offset Name"
doesnt have duplicate strings with gmoccapy.pot
linuxcnc.pot 2.8 or 2.8.2 doesnt contains
"Comments" or "Offset Name"
have duplicate strings with gmoccapy.pot
Please Log in to join the conversation.
4 years 3 months ago #248521
by HansU
Replied by HansU on topic Translate offsetpage.glade.h - dont work
These strings were moved from gmoccapy.pot to linuxcnc.pot in 2.9.
But they seem to have no effect for 2.8.
This needs some deeper investigation I guess.
But they seem to have no effect for 2.8.
This needs some deeper investigation I guess.
Please Log in to join the conversation.
4 years 3 months ago #248726
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
Can I help you with some deeper investigation?
I dont know how.
I found out, that /po/Submakefile 2.8 is different /po/Submakefile master
I dont know how.
I found out, that /po/Submakefile 2.8 is different /po/Submakefile master
Please Log in to join the conversation.
4 years 2 months ago #249122
by HansU
Replied by HansU on topic Translate offsetpage.glade.h - dont work
I figured out, that it was fixed in master by chance when I made the glade file for the calculator translatable. That was this commit:
github.com/LinuxCNC/linuxcnc/commit/921c...8fe2b2e82eddbb44314e
The important line here is
If you add this line to gmoccapy.py after line 141 (locale.bindtextdomain("gmoccapy", LOCALEDIR)) then it uses the string from src/po/cz.po for the GUI. But if you run 'make pofiles' the string moves to gmoccapy/cz.po. Probably something wrong with gettext or so.
Might be related to this change: github.com/LinuxCNC/linuxcnc/pull/542
But even taking the Submakefiles from master didn't resolve this. A bit weird and I am not so deep in how that works with gettext for glade etc.
I already spent too much time on that little issue for a version that is only bugfixed.
Even I if I had a patch that is bigger, it might be no good idea to apply it on a stable version as it is more an enhancement than a bugfix.
The important line here is
Code:
locale.bindtextdomain("linuxcnc", LOCALEDIR)
If you add this line to gmoccapy.py after line 141 (locale.bindtextdomain("gmoccapy", LOCALEDIR)) then it uses the string from src/po/cz.po for the GUI. But if you run 'make pofiles' the string moves to gmoccapy/cz.po. Probably something wrong with gettext or so.
Might be related to this change: github.com/LinuxCNC/linuxcnc/pull/542
But even taking the Submakefiles from master didn't resolve this. A bit weird and I am not so deep in how that works with gettext for glade etc.
I already spent too much time on that little issue for a version that is only bugfixed.
Even I if I had a patch that is bigger, it might be no good idea to apply it on a stable version as it is more an enhancement than a bugfix.
Please Log in to join the conversation.
4 years 2 months ago #249221
by zz912
Replied by zz912 on topic Translate offsetpage.glade.h - dont work
1) I appreciate you helping me with fixes in the stable version. It's probably not as much fun as developing new things, but I prefer to spend my time improving already good things.
2) I guess we didn't understand what I wanted from you. I didn't want to move Strings from gmoccapy.pot to linuxcnc.pot. I wanted to remove duplicates from linuxcnc.pot.
Thanks to your link I solved it:
github.com/LinuxCNC/linuxcnc/pull/1896
3) Thanks for this link:
github.com/LinuxCNC/linuxcnc/commit/921c...8fe2b2e82eddbb44314e
I think that if I add " translatable="yes" " to some places, it won't be such a big hit.
2) I guess we didn't understand what I wanted from you. I didn't want to move Strings from gmoccapy.pot to linuxcnc.pot. I wanted to remove duplicates from linuxcnc.pot.
Thanks to your link I solved it:
github.com/LinuxCNC/linuxcnc/pull/1896
3) Thanks for this link:
github.com/LinuxCNC/linuxcnc/commit/921c...8fe2b2e82eddbb44314e
I think that if I add " translatable="yes" " to some places, it won't be such a big hit.
Please Log in to join the conversation.
Time to create page: 0.072 seconds
