- GCode and Part Programs
- G&M Codes
- How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
18 Sep 2023 22:15 #281109
by Vector
How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ? was created by Vector
There's a teensy weensy fix that's needed in the
g-code.html
page:
At the bottom of that Section 2: Quick Reference Table: it's missing G97 -- it should be nestled right next to G96: same link to the tag and everything because the section on G96 documents G97 as well.
It may be that someone needs to push a propagate/generate button somewhere...
...because: when I went to github to try and make a pull request to fix that (**ridiculous, heroic bicep flexes**) the only doc I could find was:
github.com/LinuxCNC/linuxcnc/blob/master...rc/gcode/g-code.adoc
And the fix is already there.
I'm guessing some process publishes the .html from the .adoc, and perhaps it needs to be initiated?
Obviously, an almost zero priority. But I'm also wondering how it works.
Thanks!
At the bottom of that Section 2: Quick Reference Table: it's missing G97 -- it should be nestled right next to G96: same link to the tag and everything because the section on G96 documents G97 as well.
It may be that someone needs to push a propagate/generate button somewhere...
...because: when I went to github to try and make a pull request to fix that (**ridiculous, heroic bicep flexes**) the only doc I could find was:
github.com/LinuxCNC/linuxcnc/blob/master...rc/gcode/g-code.adoc
And the fix is already there.
I'm guessing some process publishes the .html from the .adoc, and perhaps it needs to be initiated?
Obviously, an almost zero priority. But I'm also wondering how it works.
Thanks!
Please Log in or Create an account to join the conversation.
18 Sep 2023 23:34 #281118
by andypugh
Replied by andypugh on topic How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
I think that the key here is that you are looking at the current (2.8) docs but looking at the development (ie 2.10) page source.
github.com/LinuxCNC/linuxcnc/blob/2.8/docs/src/gcode/g-code.txt
Doesn't have G97.
You might also notice that the file changed from .txt to .adoc too.
github.com/LinuxCNC/linuxcnc/blob/2.8/docs/src/gcode/g-code.txt
Doesn't have G97.
You might also notice that the file changed from .txt to .adoc too.
The following user(s) said Thank You: Vector
Please Log in or Create an account to join the conversation.
19 Sep 2023 00:15 #281120
by Vector
Replied by Vector on topic How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
Related question:
This doc: linuxcnc.org/docs/html/gcode/overview.html
Can also use some changes.
Similar, but different question: the corresponding (I think) github document is here: github.com/LinuxCNC/linuxcnc/blob/master.../gcode/overview.adoc
But that asciidoc doesn't have the section numbering system that shows up at the public-facing .html file, and when I do an asciidoc conversion of it, I don't get numbering either. (I do get that some deprecated markup is being used, fyi)
But the numbering is very helpful.
I think I'm going to have the same question about linuxcnc.org/docs/devel/html/gui/qtdragon.html vs github.com/LinuxCNC/linuxcnc/blob/master...rc/gui/qtdragon.adoc
So I'm wondering if I'm on the wrong channel/path for proposing changes.
Can someone set me straight?
Thanks!
This doc: linuxcnc.org/docs/html/gcode/overview.html
Can also use some changes.
Similar, but different question: the corresponding (I think) github document is here: github.com/LinuxCNC/linuxcnc/blob/master.../gcode/overview.adoc
But that asciidoc doesn't have the section numbering system that shows up at the public-facing .html file, and when I do an asciidoc conversion of it, I don't get numbering either. (I do get that some deprecated markup is being used, fyi)
But the numbering is very helpful.
I think I'm going to have the same question about linuxcnc.org/docs/devel/html/gui/qtdragon.html vs github.com/LinuxCNC/linuxcnc/blob/master...rc/gui/qtdragon.adoc
So I'm wondering if I'm on the wrong channel/path for proposing changes.
Can someone set me straight?
Thanks!
Please Log in or Create an account to join the conversation.
19 Sep 2023 00:58 #281125
by Vector
Replied by Vector on topic How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
@andypugh, thanks for responding.
So, I think you are saying if I wanted to I could fork 2.8 and suggest the change, and if approved, it would get pushed to the public facing
linuxcnc.org/docs/html/gcode/g-code.html which is 2.8. (This might not be worth anyone's effort, other than for my learning benefit)
Any guess on how long before 2.9 becomes current?
And what about the numbering question? When Rod and I worked on the Getting LinuxCNC , I guess I didn't notice that my local preview of the .adc file (using a asciidoctor plugin) didn't have numbering of the main section, but when it published with our changes, it does.
And when I do an asciidoctor conversion, it doesn't convert the .adoc to .html with section numbering.
How do I get that preview?
So, I think you are saying if I wanted to I could fork 2.8 and suggest the change, and if approved, it would get pushed to the public facing
linuxcnc.org/docs/html/gcode/g-code.html which is 2.8. (This might not be worth anyone's effort, other than for my learning benefit)
Any guess on how long before 2.9 becomes current?
And what about the numbering question? When Rod and I worked on the Getting LinuxCNC , I guess I didn't notice that my local preview of the .adc file (using a asciidoctor plugin) didn't have numbering of the main section, but when it published with our changes, it does.
And when I do an asciidoctor conversion, it doesn't convert the .adoc to .html with section numbering.
How do I get that preview?
Please Log in or Create an account to join the conversation.
19 Sep 2023 13:17 #281163
by andypugh
Well, you _could_, but in this case it's very esy for me to do it live on github:
github.com/LinuxCNC/linuxcnc/blob/2.8/docs/src/gcode/g-code.txt
Not really. It comes down to when the must-fix bugs get fixed, and when I get the time.
Replied by andypugh on topic How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
So, I think you are saying if I wanted to I could fork 2.8 and suggest the change
Well, you _could_, but in this case it's very esy for me to do it live on github:
github.com/LinuxCNC/linuxcnc/blob/2.8/docs/src/gcode/g-code.txt
Any guess on how long before 2.9 becomes current?
Not really. It comes down to when the must-fix bugs get fixed, and when I get the time.
The following user(s) said Thank You: Vector
Please Log in or Create an account to join the conversation.
- GCode and Part Programs
- G&M Codes
- How do I github an update to https://linuxcnc.org/docs/html/gcode/g-code.html ?
Time to create page: 0.127 seconds