Minor typo in Pncconf...

More
3 years 5 months ago #270574 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Yes, but moderator phillc54 provided a link that took me right to where I needed to be to create the pull request, which is only that one section of the document. I went back through the directory tree a bit but couldn't find the section mentioned above. Create or edit.
I looked at some info on how to create pull requests on the 'net but they seemed really involved... cloning, downloading, editing, uploading, etc. Seemed crazy complicated just to remove an extra space between two words.
 

Please Log in or Create an account to join the conversation.

More
3 years 5 months ago #270575 by HansU
Replied by HansU on topic Minor typo in Pncconf...
So you only didn't find the file?

Here it is: github.com/LinuxCNC/linuxcnc/blob/2.9/do.../config/pncconf.adoc

Please Log in or Create an account to join the conversation.

More
3 years 5 months ago #270576 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Correct. Thanks!
How do I go about finding things like this on my own on GitHub? Is there a guide to the structure/directory tree, or does it just come with experience?
I never would have found that.

Please Log in or Create an account to join the conversation.

More
3 years 5 months ago #270577 by HansU
Replied by HansU on topic Minor typo in Pncconf...
Just full text search in my local clone ;-)
The following user(s) said Thank You: Geosec

Please Log in or Create an account to join the conversation.

More
3 years 5 months ago - 3 years 5 months ago #270580 by Geosec
Replied by Geosec on topic Minor typo in Pncconf...
Is the 'Show Advanced Option Pages' checkbox going away in 2.9?

I was just working on another pull request, but thought I better ask before spending too much time.

ex. You can also select 'Use INI substitution for Mesa board names.' and 'Show Advanced option Pages', which make additional settings and pages available as you proceed through the configuration process. These include making PID settings available, and pages such as...

Edit: Disregard. I submitted the pull request. Let me know if/how I can do better.
Last edit: 3 years 5 months ago by Geosec.

Please Log in or Create an account to join the conversation.

Moderators: HansU
Time to create page: 0.135 seconds
Powered by Kunena Forum