Question on recent SPINDLE_9 change

More
11 Sep 2019 15:07 - 11 Sep 2019 15:08 #144828 by shasse
I am testing pncconf off of 2.8 and master, and I believe this recent change introduces a regression:

github.com/LinuxCNC/linuxcnc/commit/2ae2...b09b9dbd111acd4b282c

specifically, there is a mismatch in the generated configuration between SPINDLE_9 and SPINDLE_0 between the hal and ini files.

In build_INI.py there is the following line 299:
        # always add SPINDLE
        self.write_one_joint(file, 9, "s", "null", all_homes, False)

and line 320:
        if letter == 's':
            print >>file, "[SPINDLE_%d]" % 0
        else:

and in build_HAL.py there is (line 401):
        # Always add Spindle ##################
        self.connect_joint(file, 9, 's') # 9 for [SPINDLE_9]

I'm willing to work on a fix for this, but I am wondering what the desired behavior is. Is multi-spindle a consideration here?

Thanks!

Scott
Last edit: 11 Sep 2019 15:08 by shasse. Reason: put code in code tags

Please Log in or Create an account to join the conversation.

More
11 Sep 2019 23:06 #144842 by phillc54
Sorry to hijack your thread but...

If you are looking at spindle handling by PncConf it would be nice if there was an option to have no spindle configuation done by PncConf.

Please Log in or Create an account to join the conversation.

More
12 Sep 2019 02:49 #144882 by cmorley
Yes - oops...i did it again.
My intention was to switch to use spindle_0 as in 2.8 there is actually multiple spindle allowed. The original 9 was a shortcut of using the axie functions to write the spindle (there are 0-8 axes and so spindle was 9)

Phill it should be easy to add a checkbox on the 'base information' page.
I wonder if I can get that wrong too :)

Chris

Please Log in or Create an account to join the conversation.

More
12 Sep 2019 03:04 #144884 by phillc54

I wonder if I can get that wrong too :)

I have a knack for that as well. :ohmy:

Please Log in or Create an account to join the conversation.

More
12 Sep 2019 03:22 #144887 by shasse
Chris- I am sure it will only take you a minute to fix, but if you want me to propose a fix for the SPINDLE_9 issue, now that I understand your intention I'm happy to do that, just let me know.

Thanks!

Scott

Please Log in or Create an account to join the conversation.

More
12 Sep 2019 03:26 #144888 by cmorley
I'll fix it thanks though.
See my comment on your last pull request- thanks for the code!
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

Moderators: cmorley
Time to create page: 0.131 seconds
Powered by Kunena Forum