QtVCP reading error message

More
11 Feb 2019 07:57 #126191 by phillc54
There are a few other odd little issues I have noticed with the gcode editor.
I will have a go at 'fixing' them over the next few days and get back to you, hopefully I can save you spending too much time on them.
I will probably have some questions for you as I stumble along.

Cheers, Phill.

Please Log in or Create an account to join the conversation.

More
14 Feb 2019 05:49 - 14 Feb 2019 06:06 #126435 by phillc54
Most of the gcode editor oddities were caused when mode switching.
I noticed the editor didn't have the auto_show_mdi_status that the viewer has so I copied it across.
I also stuck setModified(False) in a few places to stop file changed dialog appearing when it shouldn't.
Attached is a git diff file of the changes I made, hopefully this is of some use.

Cheers, Phill

Edit: I have just merged master into my repo and I noticed that you had already fixed the auto_show_mdi_status
Attachments:
Last edit: 14 Feb 2019 06:06 by phillc54.

Please Log in or Create an account to join the conversation.

More
15 Feb 2019 05:41 #126523 by cmorley
Replied by cmorley on topic QtVCP reading error message
I added your code to my last push of work.
Thank you.

Chris M

Please Log in or Create an account to join the conversation.

More
15 Feb 2019 09:10 #126525 by phillc54
I have also done a bit of work on the MDI history widget, what is the best way to get it to you to have a look at.

Cheers, Phill.

Please Log in or Create an account to join the conversation.

More
15 Feb 2019 12:14 #126533 by cmorley
Replied by cmorley on topic QtVCP reading error message
If you are using Git then a git patch is the nicest - also keeps your name on the file.
Here is a link about git patches if that is new to you:
www.devroom.io/2009/10/26/how-to-create-...ly-a-patch-with-git/

you can create a pull request through Github.
github.com/LinuxCNC/linuxcnc

but a diff or even just the file is fine too.
Thank you for your contributions

Chris M

Please Log in or Create an account to join the conversation.

More
15 Feb 2019 22:39 #126589 by phillc54
Git patch sounds fine, would you prefer I post them to the forum or email to you directly.

Cheers, Phill.

Please Log in or Create an account to join the conversation.

More
16 Feb 2019 00:46 #126593 by cmorley
Replied by cmorley on topic QtVCP reading error message
Either is fine by me.

Chris M

Please Log in or Create an account to join the conversation.

Time to create page: 0.093 seconds
Powered by Kunena Forum