Code cleanup question

Hi all

I have been lurking in the code for some time now, mostly out of curiosity and to learn something new on a project that I use.
I was thinking of learning a bit more by at least trying to assist with the python3 / gtk3 porting effort on Rene's limuxcmc branch.
Python2 is EOL. GTK2 is EOL and GTK3 is already several years old. It has to be done to move forward.

One thing that became clear is that there is quite a bit of orphan and fancy footwork code (to deal with python2/3) lying around and when opening Glade for example, so many widgets are deprecated or have deprecated properties (some relatively easily rectified.)
Sure they can still be used in the short term, but the warnings hurt ones eyes

I haven't been able to find a clear answer in the forums. Does this project have a plan to get brutal and clean up properly, knowing that we may break a few things in the short term? Silly example: the HBox widget was removed in 2013 already because you can use a 1x1 table instead, which under GTK3 is actually now a Grid widget since the Table widget is deprecated. The code for HBox however is still there, I presume to satisfy some legacy requirement while not being visible to users to be used for new development.

Thanks Andy

I started playing around and found that it tends to mess up things like alignment but does not completely break the panels. That said I only scratched the surface. I didn't want to invest too much effort in a futile exercise, hence my question.

I completely understand the user experience concern. We are going through a similar transition at work redeveloping a system dating back to 2003 and having to manage user expectations and fears. It was however just not an option to keep dragging along legacy code. It makes it near impossible to onboard new developers, innovate, add features and move forward.

When you say existing panels, are you referring to user created panels or the ones included in the distribution which I believe one would at a minimum need to ensure that they remain functional?

Let me experiment a bit more and try to map out the challenges one can expect.

I think the switch to python/gtk3 is an excellent time to allow breaking of panels and code cleanup.
The GTK change will even require a different Glade editor.

Chris

I do not know a way ro update gtk2 panel to gtk3.
I spent a lot of time triing to change gmoccapy from py2 gtk2 to py3 gtk3, but I run into huge problems. Just to mention one, the color handling of the ui is completely different and Also the style is now handled over csv files.

That is the reason I stopped that PROJECT!

I decided to begin better from scratch as soon as possible, even gmoccapy is already running on py3 and gtk3 with some bugs left.

So Imho a complete brake is the only reasonable solution.

Norbert

andypugh wrote:

cmorley wrote:

I think the switch to python/gtk3 is an excellent time to allow breaking of panels and code cleanup.
The GTK change will even require a different Glade editor.

Do you know if there is any kind of upgrade path by loading existing screens into the new editor and re-saving?

unfortunately I know of no automated way to do that.

Maybe UI in C or CPP?