Translate offsetpage.glade.h - dont work

More
27 Jul 2022 13:37 #248419 by HansU
So this thread can be seen as resolved, right?

Please Log in or Create an account to join the conversation.

More
27 Jul 2022 20:31 #248460 by zz912
I made 
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/cs.po file
from linuxcnc.pot

I found, that it duplicate
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/gmoccapy/cs.po file
 

Is this duplication intentional?
 
Attachments:

Please Log in or Create an account to join the conversation.

More
27 Jul 2022 20:49 #248464 by zz912
I have another problem.

My src/po/cs.po file is not same as your src/po/cs.po file.

My src/po/cs.po file dont contains
"Comments" or "Offset Name"

Could you please remove your linuxcnc.pot , rebuild LCNC and check it?

Please Log in or Create an account to join the conversation.

More
27 Jul 2022 21:24 #248470 by HansU

I found, that it duplicate
/home/zdenek/linuxcnc/linuxcnc-2.8/src/po/gmoccapy/cs.po file

What do you mean with this? These two cs.po files should be completely different. One derived from gmoccapy.pot, the other from linuxcnc.pot

My src/po/cs.po file dont contains
"Comments" or "Offset Name"

But it should. Look into linuxcnc.pot, it does contain these strings.

Please Log in or Create an account to join the conversation.

More
27 Jul 2022 21:40 #248471 by zz912
I agree with what you write. My error looks like the tool that generates the linuxcnc.pot file went wrong.

In my linuxcnc.pot file is merged gmoccapy.pot file.

But it should. Look into linuxcnc.pot, it does contain these strings.

I made /src/po/cs.po file from linuxcnc.pot

Are you working on branch 2.8?

Please Log in or Create an account to join the conversation.

More
28 Jul 2022 06:33 #248510 by zz912
You probably use branch 2.9

linuxcnc.pot 2.9 contains
"Comments" or "Offset Name"
doesnt have duplicate strings with gmoccapy.pot

linuxcnc.pot 2.8 or 2.8.2 doesnt contains
"Comments" or "Offset Name"
have duplicate strings with gmoccapy.pot

Please Log in or Create an account to join the conversation.

More
28 Jul 2022 10:39 #248521 by HansU
These strings were moved from gmoccapy.pot to linuxcnc.pot in 2.9.
But they seem to have no effect for 2.8.
This needs some deeper investigation I guess.
The following user(s) said Thank You: zz912

Please Log in or Create an account to join the conversation.

More
31 Jul 2022 12:00 #248726 by zz912
Can I help you with some deeper investigation?
I dont know how.
I found out, that /po/Submakefile 2.8 is different /po/Submakefile master 

Please Log in or Create an account to join the conversation.

More
05 Aug 2022 15:20 - 06 Aug 2022 20:49 #249122 by HansU
I figured out, that it was fixed in master by chance when I made the glade file for the calculator translatable. That was this commit: github.com/LinuxCNC/linuxcnc/commit/921c...8fe2b2e82eddbb44314e

The important line here is
locale.bindtextdomain("linuxcnc", LOCALEDIR)

If you add this line to gmoccapy.py after line 141 (locale.bindtextdomain("gmoccapy", LOCALEDIR)) then it uses the string from src/po/cz.po for the GUI. But if you run 'make pofiles' the string moves to gmoccapy/cz.po. Probably something wrong with gettext or so.
Might be related to this change: github.com/LinuxCNC/linuxcnc/pull/542
But even taking the Submakefiles from master didn't resolve this. A bit weird and I am not so deep in how that works with gettext for glade etc.
I already spent too much time on that little issue for a version that is only bugfixed.
Even I if I had a patch that is bigger, it might be no good idea to apply it on a stable version as it is more an enhancement than a bugfix.
Last edit: 06 Aug 2022 20:49 by HansU.
The following user(s) said Thank You: zz912

Please Log in or Create an account to join the conversation.

More
06 Aug 2022 20:07 #249221 by zz912
1) I appreciate you helping me with fixes in the stable version. It's probably not as much fun as developing new things, but I prefer to spend my time improving already good things.

2) I guess we didn't understand what I wanted from you. I didn't want to move Strings from gmoccapy.pot to linuxcnc.pot. I wanted to remove duplicates from linuxcnc.pot.
Thanks to your link I solved it:
github.com/LinuxCNC/linuxcnc/pull/1896

3) Thanks for this link:
github.com/LinuxCNC/linuxcnc/commit/921c...8fe2b2e82eddbb44314e
I think that if I add " translatable="yes" " to some places, it won't be such a big hit.

Please Log in or Create an account to join the conversation.

Moderators: newbynobi
Time to create page: 0.102 seconds
Powered by Kunena Forum