Gmocappy defects in release 2.9.2
26 Dec 2023 22:05 #289117
by Serg452
Gmocappy defects in release 2.9.2 was created by Serg452
In this release the turtle jog bug is solved, but the old tails remain. These are not critical errors, but fixing them will make gmoccapy better. Perhaps the developers will take this into account in the 2.9.3 release.
1. unreadable line in dark themes
2.In AUTO mode some hbox icons of the wrong small size, green marked the correct corresponding vbox. This does not depend on the set of icons.
1. unreadable line in dark themes
2.In AUTO mode some hbox icons of the wrong small size, green marked the correct corresponding vbox. This does not depend on the set of icons.
Attachments:
Please Log in or Create an account to join the conversation.
28 Dec 2023 16:06 #289258
by HansU
Replied by HansU on topic Gmocappy defects in release 2.9.2
Regarding the icon sizes: The reason why some of them are bigger than the others is because some of the classic icons are in a landscape format so they have to be bigger to have same height while having a bigger width.
I must admit that this is not optimal for other icon themes.
As I understood you want the lower buttons all in 48x48. But this would look weird with the other icon themes.
Look at this for example:
I will think about what a good solution could be. Until that, you can change the icon sizes wit a user command file
(see linuxcnc.org/docs/html/gui/gmoccapy.html#_user_command_file) with the following content
I must admit that this is not optimal for other icon themes.
As I understood you want the lower buttons all in 48x48. But this would look weird with the other icon themes.
Look at this for example:
I will think about what a good solution could be. Until that, you can change the icon sizes wit a user command file
(see linuxcnc.org/docs/html/gui/gmoccapy.html#_user_command_file) with the following content
icon_configs = [
# widget, named_icon, size
# auto mode buttons
("img_open", "open_file", 48),
("img_reload1", "refresh", 48),
("img_run", "play", 48),
("img_stop", "stop", 48),
("img_pause", "pause", 48),
("img_pause_active", "pause_active", 48),
("img_step", "step", 48),
("img_run_from", "run_from_line", 48),
("img_editor", "edit_code", 48),
("img_skip_optional_active", "skip_optional_active", 48),
("img_skip_optional_inactive", "skip_optional_inactive", 48),
]
# default style context see TODO below
default_style = Gtk.Button().get_style_context()
failed_icons = 0
for widget_name, icon_name, size in icon_configs:
try:
image = self.widgets[widget_name]
pixbuf = icon_theme_helper.load_symbolic_from_icon_theme(self.icon_theme, icon_name, size, default_style)
image.set_from_pixbuf(pixbuf)
image.set_size_request(size, size)
except BaseException as err:
LOG.warning(f"Failed to change icon for <{widget_name}> to '{icon_name}': {str(err)}")
failed_icons += 1
Attachments:
Please Log in or Create an account to join the conversation.
28 Dec 2023 18:52 #289272
by HansU
Replied by HansU on topic Gmocappy defects in release 2.9.2
I implemented the Theme thingy now as a setting, so will be available soon 
github.com/LinuxCNC/linuxcnc/pull/2811
github.com/LinuxCNC/linuxcnc/pull/2811
Please Log in or Create an account to join the conversation.
28 Dec 2023 21:29 #289282
by Serg452
Replied by Serg452 on topic Gmocappy defects in release 2.9.2
Great idea!I implemented the Theme thingy now as a setting, so will be available soon
github.com/LinuxCNC/linuxcnc/pull/2811
Please Log in or Create an account to join the conversation.
28 Dec 2023 22:25 #289286
by Serg452
Replied by Serg452 on topic Gmocappy defects in release 2.9.2
Everything is fine with the buttons.
And there is a problem with the code - the selected code is clearly visible, and the active one is hidden against a bright background.
You have to replace in the code with something darker self.add_mark_category ('motion', '# 1c1c1c')
Is it possible to take this to the USER_COMMAND_FILE to exclude overwriting during updates?
And there is a problem with the code - the selected code is clearly visible, and the active one is hidden against a bright background.
You have to replace in the code with something darker self.add_mark_category ('motion', '# 1c1c1c')
Is it possible to take this to the USER_COMMAND_FILE to exclude overwriting during updates?
Attachments:
Please Log in or Create an account to join the conversation.
Time to create page: 0.147 seconds