Qtgragon Versa Probe Bug ? probe_routines.py

More
30 Nov 2024 11:42 - 30 Nov 2024 11:52 #315639 by zieluch
Hi Guys,

I think I found a bug in the probe_routines.py for versa probe. When Trying to probe from outside from 4 sides in the current setup I was not able to make it working. ( I always had to probe very end X+ and Y+ with adequate searching  distance). Not sure if this is happening only for me but but this was pretty anoying because even I found center I couldn't from ceter position run routine again to double check.

Someone might find this helpful i adjusted probe_routines.py file (/usr/lib/python3/dist-packages/qtvcp/widgets/probe_routines.py)
github.com/LinuxCNC/linuxcnc/blob/master...ts/probe_routines.py

line 1089
aa = (2 * self.data_side_edge_length) + self.data_latch_return_dist + self.data_xy_clearance
replace with:
aa = 2 * (self.data_side_edge_length + self.data_latch_return_dist + self.data_xy_clearance)
line 1054
aa = (2 * self.data_side_edge_length) + self.data_latch_return_dist + self.data_xy_clearance
replace with:
aa = 2 * (self.data_side_edge_length + self.data_latch_return_dist + self.data_xy_clearance)
Last edit: 30 Nov 2024 11:52 by Aciera. Reason: code formating changes
The following user(s) said Thank You: Aciera

Please Log in or Create an account to join the conversation.

More
30 Nov 2024 11:53 - 30 Nov 2024 11:54 #315640 by Aciera
I fixed the formatting.

Maybe you want to file this as an issue or as a pull request on github?
Last edit: 30 Nov 2024 11:54 by Aciera.

Please Log in or Create an account to join the conversation.

More
30 Nov 2024 18:09 #315669 by zieluch
issue
github.com/LinuxCNC/linuxcnc/issues/3196
pull
github.com/LinuxCNC/linuxcnc/pull/3197

I home this is correct, if not please let me know.
The following user(s) said Thank You: Aciera

Please Log in or Create an account to join the conversation.

More
01 Dec 2024 07:17 #315709 by cmorley
Merged. thank you.
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

Moderators: cmorley
Time to create page: 0.068 seconds
Powered by Kunena Forum