M19 and spindle-index-enable issues

Hi all

Not sure if this is still relevant. I am using this "new" orient comp from Andy (recompiled it as orient2). And I have to say, this actually works great!

The only thing I changed is: uncomment "is_oriented = 0" (otherwise I was not able to run multiple M19 commands in a row).
This changes the behavior of the -is-oriented pin --> So i use the oneshot function to make the signal stay true longer and activate the spindle brake and some other stuff. Might add another input to the comp, so the i"s-oriented" pin can be reset with M5 or an other signal...)

Before I saw this, I had to use tallas83 idea to orient a spindle (which requires much more signals/pins  & connections).

This should be added to the main fork in my opinion (maybe this was already done)?

One improvement in my setup would probably be to run the indexing only once (and then change the mode to 0) and after that do a few orientation commands. That should make it a bit faster as a constant rehoming is not necessary after every orientation (espescially if the spindle is not running in velocity mode in between).
 

So, how did you get this to work: I thought it meant to add 16 to the P word in the M19 command but that does not work as only values 0,1 or 2 are accepted by the interpreter.

Yes that's the issue with the M19 command. But could probably be changed in a new release ??
I connect the orient.mode signal to a signal and then manually switch the mode.
An improvement might be to use a custom M command to change the mode (via mux2 or multiselect component)

One thing I might try is to change the orient.comp to have a input for running the index function, that can be controlled easily via hal or M command.

About the brake control:
I found the spindle.xx.locked pin in the documentation which goes high when orient ist done (and low with M5 or a new M19 command) --> it is perfect for controlling the spindle brake !

@andy, seems I have missed your reply:

The point of IO pins is to only write any state to them when you want to set the state, and let other parts of the net be in charge at other times.

Looking at your code for case 0, which is the initial state, you are setting 'index_enable = 0' so this version of the component permanently forces 'orient.index_enable' low until an orient command is issued (ie 'orient.enable' goes true):

 Your code looks like it will always set index_enable true?

No, my version forces homing to index because the mechanism with adding 16 to the p word does not work and 'orient.index-enable' is not written to unless spindle orientation has been called (ie 'orient.enable' is true) because 'index_enable=0' is now inside the if (enable) { statement.

@scda

The only thing I changed is: uncomment "is_oriented = 0" (otherwise I was not able to run multiple M19 commands in a row).

After digging out my config from back then I notice that I made the same change.

Yes that's the issue with the M19 command. But could probably be changed in a new release ??

thanks for confirming that as I thought I was missing something and yes that could indeed be changed.

What makes me wonder is why  constantly forcing index-enable low does not cause a problem for you.

So I modified the orient.comp such that it has an index enable cmd pin (i/o).

This allows it to start the orientation with indexing, once done, it will disable the automatic indexing.

It can still be activate again by setting the index enable cmd pin high again (eg. via custom M code).

Only software signals can enable the automatic indexing before spindle orient.

In hal i then use: setting this high manually (or via logic: for example put this high after an M3 command has been issued), it will make the system home once and do a spindle orient.



Cheers, 
David