remap.cycle in 2.9.1 broken?

More
15 Dec 2023 15:44 #288223 by MaHa
Remap cycle worked perfectly in 2.8, also the example loaded fine. In version 2.9 i am not even able to load the example. In my config, its all setup, as it worked before, and it gives the same error as the example.


 
Attachments:

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 16:13 #288230 by MaHa
Replied by MaHa on topic remap.cycle in 2.9.1 broken?
One problem found:  in   cycle.ini   of the example, the [PYTHON] stanza is missing with all the PATH_   entrys. Fixed that, but still it is not working

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 16:58 - 15 Dec 2023 17:21 #288236 by Aciera
Replied by Aciera on topic remap.cycle in 2.9.1 broken?
I'm getting:

  File "/home/user/linuxcnc-2_9-oct/configs/sim/axis/remap/cycle/../../nc_files/remap_lib/python-stdglue/stdglue.py", line 361, in cycle_prolog
    if self.sticky_params[r.name] <= 0.0:

TypeError: '<=' not supported between instances of 'dict' and 'float'

[edit]
Changing line 361 in '/home/user/linuxcnc-2_9-oct/nc_files/remap_lib/python-stdglue.stdglue.py'

to

            if self.sticky_params[r.name]["r"] <= 0.0:

gives me this when I run the demo code, so I guess something is not quite right yet:
 
 
Attachments:
Last edit: 15 Dec 2023 17:21 by Aciera.

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 17:22 #288239 by andypugh
I think the answer is to change the stdglue.py line 361 to:
       else:
            if self.sticky_params[r.name]['r'] <= 0.0:
                return "%s: R word must be > 0 if used (%.4f)" % (r.name, words["r"])

(ie, append to index into the dict to find the float value.)

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 17:25 #288240 by andypugh
Looks like we both came to the same conclusion.

Curiously, you can't run the G84.3 command from the MDI tab, but it works in G-code.

On a normal installation the strdglue.py file is found in /usr/share/linuxcnc/ncfiles/remap_lib/python_stdglue/

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 17:37 - 15 Dec 2023 17:57 #288241 by Aciera
Replied by Aciera on topic remap.cycle in 2.9.1 broken?

Curiously, you can't run the G84.3 command from the MDI tab, but it works in G-code.
 

Not sure but it may be missing values that get set by G84.2 if it is run in the same gcode program.

[edit]
or maybe rather some kind of python context as it seems to be unable to find it
Last edit: 15 Dec 2023 17:57 by Aciera.
The following user(s) said Thank You: MaHa

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 18:03 #288247 by andypugh
I think it's the call to init_stdglue:
def cycle_prolog(self,**words):
    # self.sticky_params is assumed to have been initialized by the
    # init_stgdlue() method below

Anyway: github.com/LinuxCNC/linuxcnc/commit/052a...6ef4e3f0efec06f717b7
The following user(s) said Thank You: MaHa, Aciera

Please Log in or Create an account to join the conversation.

More
15 Dec 2023 19:39 #288262 by MaHa
Replied by MaHa on topic remap.cycle in 2.9.1 broken?
Great support. It is working now. Thank you

Please Log in or Create an account to join the conversation.

Time to create page: 0.134 seconds
Powered by Kunena Forum