Tool offset patch

jlviloria
Offline
Platinum Member

15 Apr 2015 10:07 #57813 by jlviloria

Replied by jlviloria on topic Re:Tool offset patch

Chris, but this only works with remap "T" or apply either way the G43.2 or would apply differently.

I would like to apply diametrically wear. but I have no idea where to change this.

thanks,

Jorge Viloria

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

15 Apr 2015 16:50 - 15 Apr 2015 16:54 #57820 by andypugh

Replied by andypugh on topic Re:Tool offset patch

cmorley wrote:
I wondered if a modified tool_edit widget would be better for lathes:

Yes, this would be useful at the moment.

Longer term, if the tool table makes the transition to a database,
then things get even more "interesting" for tooledit..

~~I wonder how one persuades the GUIs to call the alternative tooledit?~~

The tooleditor is configurable in the INI file (for Axis at least)
www.linuxcnc.org/docs/html/config/ini_co...#sub:DISPLAY-section
TOOL_EDITOR

Last edit: 15 Apr 2015 16:54 by andypugh.

Please Log in or Create an account to join the conversation.

cmorley
Offline
Moderator

16 Apr 2015 11:16 #57827 by cmorley

Replied by cmorley on topic Re:Tool offset patch

the tool edit widget I was working on is used with gladeVCP.

As it is you would have to switch from the standard tooledit to this modified one but I might be able to just make it an option of the original widget.

It depends on how ugly the changes are.

Yes having a different tool database would be oh so better!

Chris M

Please Log in or Create an account to join the conversation.

cmorley
Offline
Moderator

16 Apr 2015 11:18 #57828 by cmorley

Replied by cmorley on topic Re:Tool offset patch

jlviloria wrote:
Chris, but this only works with remap "T" or apply either way the G43.2 or would apply differently.

I would like to apply diametrically wear. but I have no idea where to change this.

thanks,

Jorge Viloria

It seems linuxcnc doesn't support diametrical wear offsets - as far as I can tell

Chris M

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

16 Apr 2015 15:36 #57831 by andypugh

Replied by andypugh on topic Re:Tool offset patch

jlviloria wrote:
I would like to apply diametrically wear. but I have no idea where to change this.

I think that this is surprisingly hard.
You could (relatively) easily have a modified tool editor that displayed and accepted value dimensions but stored radius in the tool table. But that would not help with G10 (which can't be re-mapped)

Yo could possibly re-map G10.1 or G11 to do a G10 with half the offset given.

Please Log in or Create an account to join the conversation.

LAIR82
Offline
Platinum Member

16 Apr 2015 18:05 #57835 by LAIR82

Replied by LAIR82 on topic Re:Tool offset patch

cmorley wrote:
Lairs:

I wondered if a modified tool_edit widget would be better for lathes:
The wear number is beside the offset rather then as a separate tool.

interested? It's not quite done yet...

Chris M

We actually would rather have the Wear Offset values on a separate tab all together, that way the operator doesn't fat finger the wrong entry, then possibly scrap a part, or even worse yet crash the machine.

All the other controls in our shop have the tool position data on one page normally called "Fixed Offsets" then the wear data is in another tab normally called "Assignable Offsets".

But I'm sure yours would be OK for a lot of the guys that are the only operator of the machine, and are paying attention a lot better than most of the guys in our shop, that when it breaks, or gets scrapped it's always, "Screw it, its not my money"

Rick

Please Log in or Create an account to join the conversation.

jlviloria
Offline
Platinum Member

16 Apr 2015 20:44 - 16 Apr 2015 21:38 #57839 by jlviloria

Replied by jlviloria on topic Re:Tool offset patch

Chris, Andy,
Thanks for your reply.
Well we have a problem with the operators of the machines, all machines with commercial control is diametrical wear. and most of the errors of the piece is "diametrically compensate for wear.! is not my fault"
I'm just a newbie in programming. I tried to read the code and applies form as G43.2 think I have found a solution for me.
it may be something "easy" for you, but I wonder if these changes'm not breaking LinuxCNC. I have only been tested in simulator. any serious review helpful.

file = interp_convert.cc
line = 5178

} else if (g_code == G_43_2) {
    CHKS((!block->h_flag), (_("G43.2: H-word missing")));
    CHP((find_tool_pocket(settings, block->h_number, &pocket_number)));
    tool_offset = settings->tool_offset;
    if(_setup.lathe_diameter_mode){
      tool_offset.tran.x += (USER_TO_PROGRAM_LEN(settings->tool_table[pocket_number].offset.tran.x)/2);
    }else{
      tool_offset.tran.x += USER_TO_PROGRAM_LEN(settings->tool_table[pocket_number].offset.tran.x);
    }
    tool_offset.tran.y += USER_TO_PROGRAM_LEN(settings->tool_table[pocket_number].offset.tran.y);

The logic is working with diameter mode compensates for wear in diameter mode.
Please help me if this is feasible and does not break LinuxCNC gives me panic a machine try not to make a mistake.

thanks.

Jorge Viloria

Last edit: 16 Apr 2015 21:38 by jlviloria.

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

16 Apr 2015 22:13 #57841 by andypugh

Replied by andypugh on topic Re:Tool offset patch

My concern is that your change to LinuxCNC will disappear if LinuxCNC is updated. So you might end up with some machines working one way, and others another way.
Being inconsistent is worse than being "wrong" :-)

How do your operators set the offset? Do they edit the tool-table, touch-off or use G10?

Please Log in or Create an account to join the conversation.

jlviloria
Offline
Platinum Member

16 Apr 2015 23:32 #57845 by jlviloria

Replied by jlviloria on topic Re:Tool offset patch

use the system, remap that is in the example of fanucy.

work in mm and use the code "G7" for all lathes with LinuxCNC.

I do not update often LinuxCNC and apply a .diff because I have my custom GUI (custom gmoccapy).

The important thing right now if that change is really good, this change work?
that later will not be the cure worse than the disease. and damage any machine.

Do not think LinuxCNC maintainers accept this change and remain permanent. ;-)

when we have active G7 and we will compensate AXIS asks us to enter the diameter. and when this active G8 calls us to enter the radius.

I think it could work.

Jorge Viloria

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

17 Apr 2015 19:25 #57861 by andypugh

Replied by andypugh on topic Re:Tool offset patch

jlviloria wrote:
The important thing right now if that change is really good, this change work?
that later will not be the cure worse than the disease. and damage any machine.

Which GUI are you using?

Axis already makes changes in Diameter if you are in G7 mode. I think it does that with a G10.

So, one way to do what you want to do would be to add a special button (GladeVCP. PyVCP) that changes the tool table by a G10 command with a calculation.

You could imagine having radius and diameter buttons, even.

Please Log in or Create an account to join the conversation.

Time to create page: 0.137 seconds