Carousel does not home
- terkaa
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 261
- Thank you received: 3
			
	
						15 Jun 2016 20:33				#76121
		by terkaa
	
	
		
			
	
			
			 		
													
	
				Replied by terkaa on topic Carousel does not home			
			
				Ok,  I have started writing custom HAL component ARMATC. That will be main component commanding also carousel component. Lets see how it turns out 
Tero
					
Tero
Please Log in or Create an account to join the conversation.
- terkaa
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 261
- Thank you received: 3
			
	
						21 Jun 2016 14:49		 -  21 Jun 2016 14:50		#76347
		by terkaa
	
	
		
			
	
	
			 		
													
	
				Replied by terkaa on topic Carousel does not home			
			
				Hi,
I am seeing now that after homing current-position is 0. Why is this? It should be 1.
Tero
					I am seeing now that after homing current-position is 0. Why is this? It should be 1.
Tero
		Last edit: 21 Jun 2016 14:50  by terkaa.			
			Please Log in or Create an account to join the conversation.
- andypugh
- 
				  
- Away
- Moderator
- 
				  
		Less
		More
		
			
	
		- Posts: 19677
- Thank you received: 4554
			
	
						21 Jun 2016 17:21		 -  21 Jun 2016 17:21		#76360
		by andypugh
	
	
		
			
				
That definitely looks like a bug
github.com/LinuxCNC/linuxcnc/blob/master...s/carousel.comp#L246
It sets P to 1, but the next time through P is set to current_position before cirrent_position is set to P.
There needs to be an extra line inserted:
			
					
	
	
			 		
													
	
				Replied by andypugh on topic Carousel does not home			
			I am seeing now that after homing current-position is 0. Why is this? It should be 1.
That definitely looks like a bug

github.com/LinuxCNC/linuxcnc/blob/master...s/carousel.comp#L246
It sets P to 1, but the next time through P is set to current_position before cirrent_position is set to P.
There needs to be an extra line inserted:
    case 11: // waiting for index & pulse
        if  ( (! old_index) && (sense(0) && sense(1)) ){ // index found
            p = 1;
            current_position = 1;
            homed = 1;
            homing = 0;
            active = 0;
            state = 0;
        }
        old_index = (sense(0) && sense(1));
        break; // So that we don't see the tool1 pulse twice
    }
		Last edit: 21 Jun 2016 17:21  by andypugh.			
	
		The following user(s) said Thank You: terkaa 	
			Please Log in or Create an account to join the conversation.
- terkaa
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 261
- Thank you received: 3
			
	
						21 Jun 2016 17:38				#76361
		by terkaa
	
	
		
			
	
			
			 		
													
	
				Replied by terkaa on topic Carousel does not home			
			
				Ok,
Thanks for checking this. I also noted that when I command jog fwd/rev from my armatc component instead of carousel.ready I had to use !carousel.active because jogging does not need enable it also does not give ready flag. ATC is now working to about middle point of toolchange. I have to implement a spindle orient component tomorrow to go forward with tool change. Component that is readily made does not fit because this spindle does not have feedback from main shaft, only from motor and there is a gearbox between. Also it has mechanical pin that goes into hole to keep spindle still while changing tool. Lets see if I can make it happen....
Tero
					Thanks for checking this. I also noted that when I command jog fwd/rev from my armatc component instead of carousel.ready I had to use !carousel.active because jogging does not need enable it also does not give ready flag. ATC is now working to about middle point of toolchange. I have to implement a spindle orient component tomorrow to go forward with tool change. Component that is readily made does not fit because this spindle does not have feedback from main shaft, only from motor and there is a gearbox between. Also it has mechanical pin that goes into hole to keep spindle still while changing tool. Lets see if I can make it happen....
Tero
Please Log in or Create an account to join the conversation.
- terkaa
- Offline
- Elite Member
- 
				  
		Less
		More
		
			
	
		- Posts: 261
- Thank you received: 3
			
	
						22 Jun 2016 07:58				#76399
		by terkaa
	
	
		
			
	
			
			 		
													
	
				Replied by terkaa on topic Carousel does not home			
			
					Please Log in or Create an account to join the conversation.
		Time to create page: 0.058 seconds	
