WHB04B-4 Lead Switch Issue

I recently purchased a WHB04B-4 pendant. The majority of it works using LinuxCNC 2.8 except the lead function. When I turn the step rotary switch to lead, it does not produce the desired results.

I looked at the source code for this user component and it seems the issue is the lead switch position uses a different code for the 4 axis version of the pendant vs the 6 axis.

This link says that this issue was fixed and merged into the code in May, but the current version in github does not seem to conatain this change
github.com/LinuxCNC/linuxcnc/pull/987

Looking at the USB event, my device uses code 0x9B instead of 0x1C for the lead as shown in the current source code.

Does anyone know if this has been implemented and if so, how does one get the latest version that would contain this fix?
If its not released, is there any good instructions on how I can compile this module myself?

Thanks
Shawn

 

2.8.2. I just downloaded and installed it a month ago.

I downloaded the souce code and this issue still exits in version 2.9.

I was able to make the change and recompile version 2.82 and fixed the issue.

Hello

Sorry if the actual patch does not work fine this is strange for me because i have test both situation.

If you have a working patch allowing the two value to be accepted, please can you ask a PR.

Best regards

Oh, I now see where you changed the code. Not sure why that does not work for me. 

I just changed line 335 in pendant.cc to use the other code and that works

lead(0x1c, "Lead", ""),   => lead(0x9b, "Lead", ""),  

I can try and add some debugging info to see why your code is not executed for me.

Your welcome, all patch and correction can be really appreciated.

I see you patched these two functions

void Pendant::dispatchFeedEventToHandwheel(const KeyCode& feed, bool isActive)
void Pendant::dispatchActiveFeedToHal(const KeyCode& feed, bool isActive)

When I  look at the value of key.code when I turn the knob to lead, the value is always 0x00 so your || condition key.code == 0x96 is never true

I think line 337 in FeedRotaryButtonCodes::FeedRotaryButtonCodes() :

undefined(0x00, "", ""),

sets the key code to 0x00 because 0x9B is not in the table for permisable values.

Shawn



 

I made changes like in the following files and it seems to work for me. I renamed pendant.cc to pendant.txt as the forums do not allow .cc files for some reason.

Shawn

 
 

Hi Slammers

I'm facing very similar issues with my wh04b-4, I would greatly appreciate it if you can help me figure out how to compile this driver.  I want to make to various changes to the source. I'm happy enough with making the changes - its the compile process that's new to me.

Thanks Bally
 

What is I just give your the compiled file? I guess that would only work if you are using the same revision of LinuxCNC that I have. Which is 2.8.