LOGOPEN - logging HAL PINS?

Hello...

We have command (LOGOPEN, filename) to open file and have chance to log some stuff. I have a lot of situation where that can be very useful. But got problem as Log should be closed before some other application can read log.
So I think that command be more usseful if we can configure it to NOT truncate log file. something like:

(LOGOPEN, filename)
old way to truncate filename

(LOGOPEN, filename,append)
to preserve old data and append new to the end.


And other one what to put into log?
(LOG, some text)
(LOG,#<named_parameter>)

I like to expand that to
(LOG,#<HAL_PIN>)

In many time I need to save current coordinate and have problems as they are not available. The only way I find is to save coordinate with G28.1 and then save variable. But isn't realy good as the coordinate are machine coordinate and in most cases are different of coordinates shown in AXIS DRO dysplay. Making HAL pin with correct DRO value isn't so hard but how to put that in some other routine or to write to file? Someone will say that I can use teach-in.py script for that. And I wil say try to do that in regular basis...

Does realy only me need that stuff?!?

Slavko.

andypugh wrote:
.

The way I do it is:

G92 x0 y0 z0 (store position)
g92.2
#<x> = #5211
#<y> = #5212
#<z> = #5213
g92.1

But that only works if you are not using G92 offsets at the time. I guess you _could_ store the G92 offsets then put them back.

Just does what I needed...
And I changed LOGOPEN to not restore existing file.. Hopefuly that will someone check and updated the source.

Just don't know where to post.. Forum? mailing list? .....

... just to be sure to someone of 'right' ones see that post I duplicate post here.

Hello...

I was trying to change behaviour of (LOGOPEN, filename) feature to not
truncate file when oppened (to add)
As my knowledge with C is not good I can't manage to do in way I like
and to be good for others too.
My idea was to use (LOGOPEN, filename) as is and (LOGOPEN, filename,
append) to append to file.
But I can't find a way to do it. So After little twigeling I manage like
this:

(LOGOPEN, filename) as is
(LOGOPEN, _filename) to append to the file. (filename start's with
underscore)

and change was done in src/emc/task/emccanon.cc

the old way is:

void LOGOPEN(char *name) {
if(logfile) fclose(logfile);
logfile = fopen(name, "wt");
fprintf(stderr, "LOGOPEN(%s) -> %p\n", name, logfile);
}


changed to:

void LOGOPEN(char *name) {
if(logfile) fclose(logfile);
if (name[1] == '_') {
logfile = fopen(name, "at");
} else {
logfile = fopen(name, "wt");
}
fprintf(stderr, "LOGOPEN(%s) -> %p\n", name, logfile);
}


It's works. But can someone check if maybe I make something dumb, and to
update that in 2.5.0~pre? (probably comment in manual is good to have too)

Thanks
Slavko.

p.s.
What is 'correct' way to post such changes?!

I managed to add command (LOGAPPEND,filename) and posted patch in emc-developer maillist. Hopefuly someone will see that and apply..

andypugh wrote:

They did.

I am jealous, my patches hang about for months.

I just have luck two times.. (1'st time in life)
1. I managed to write that with my knowledge. (well in real I didn't write anithing, I just copy/paste few lines and change name . The hardest is what/where to do that. So simple operation but in 5 places to do.)
2. The patch is acepted..