ESTOP button behavior
- snowgoer540
- Topic Author
- Offline
- Moderator
Less
More
- Posts: 2394
- Thank you received: 782
29 Dec 2020 14:28 #193423
by snowgoer540
ESTOP button behavior was created by snowgoer540
More questions as a result of QTPlasmaC testing:
With regard to the ESTOP button (which I understand to be one of the existing LCNC widgets), the current behavior on a live machine with a physical estop is not consistent with previous GUI experiences (AXIS).
1. Currently if I start QTPlasmaC with the hardware estop reset (not pressed), the GUI ignores it. I have to press the estop, and then reset the estop for the GUI to pick up that the machine is not estop'd. Also, clicking the estop GUI in this state doesn't have any effect (meaning the power button does not become active).
2. If I start QTPlasmaC with the hardware ESTOP pressed, QT will allow me to click the GUI ESTOP and it will change color, but it has no effect (as the hardware ESTOP is pressed). In order to be consistent with other GUIs, the color should not change.
To summarize:
1. If the hardware estop is pressed on launch, GUI should reflect this in the GUI and not be clickable.
2. If the hardware estop is in reset condition upon launch, GUI should reflect this and show as not being estopped.
3. The GUI estop is clickable when the machine is powered on as a (albeit terrible) means of estoping the machine.
4. If the machine is estopped via the GUI but not the hardware, clicking estop again should bring it out of estop.
We are unsure if the way it currently is expected/unexpected behavior on QT's part, or if we need to make a new button with custom code to adapt it for consistent behavior among the other GUIs.
With regard to the ESTOP button (which I understand to be one of the existing LCNC widgets), the current behavior on a live machine with a physical estop is not consistent with previous GUI experiences (AXIS).
1. Currently if I start QTPlasmaC with the hardware estop reset (not pressed), the GUI ignores it. I have to press the estop, and then reset the estop for the GUI to pick up that the machine is not estop'd. Also, clicking the estop GUI in this state doesn't have any effect (meaning the power button does not become active).
2. If I start QTPlasmaC with the hardware ESTOP pressed, QT will allow me to click the GUI ESTOP and it will change color, but it has no effect (as the hardware ESTOP is pressed). In order to be consistent with other GUIs, the color should not change.
To summarize:
1. If the hardware estop is pressed on launch, GUI should reflect this in the GUI and not be clickable.
2. If the hardware estop is in reset condition upon launch, GUI should reflect this and show as not being estopped.
3. The GUI estop is clickable when the machine is powered on as a (albeit terrible) means of estoping the machine.
4. If the machine is estopped via the GUI but not the hardware, clicking estop again should bring it out of estop.
We are unsure if the way it currently is expected/unexpected behavior on QT's part, or if we need to make a new button with custom code to adapt it for consistent behavior among the other GUIs.
Please Log in or Create an account to join the conversation.
- cmorley
- Offline
- Moderator
Less
More
- Posts: 7760
- Thank you received: 2055
29 Dec 2020 17:24 #193440
by cmorley
Replied by cmorley on topic ESTOP button behavior
I need more info.
Is the gui estop a check button or momentary?
how does the estop chain get from hardware to linuxcnc?
Yes the estop as coded assumes it can estop/clear at any time.
It should follow the state of linuxcnc though.
I can see it needs some work with hardware handshaking.
I'll have to delve into it a bit.
Is the gui estop a check button or momentary?
how does the estop chain get from hardware to linuxcnc?
Yes the estop as coded assumes it can estop/clear at any time.
It should follow the state of linuxcnc though.
I can see it needs some work with hardware handshaking.
I'll have to delve into it a bit.
The following user(s) said Thank You: snowgoer540
Please Log in or Create an account to join the conversation.
- snowgoer540
- Topic Author
- Offline
- Moderator
Less
More
- Posts: 2394
- Thank you received: 782
29 Dec 2020 18:29 #193447
by snowgoer540
Replied by snowgoer540 on topic ESTOP button behavior
I’m not sure the technical name. In a sim you can click it and it changes color and stays changed until you click it again (not how it should work with hardware button in the mix). I’d call it a latching button?
Please Log in or Create an account to join the conversation.
- rodw
- Offline
- Platinum Member
Less
More
- Posts: 10747
- Thank you received: 3543
30 Dec 2020 07:48 #193495
by rodw
Replied by rodw on topic ESTOP button behavior
Have you set up the external estop in hal?
Ref:
forum.linuxcnc.org/47-hal-examples/25861-external-e-stop
Ref:
forum.linuxcnc.org/47-hal-examples/25861-external-e-stop
Please Log in or Create an account to join the conversation.
- phillc54
- Offline
- Platinum Member
Less
More
- Posts: 5698
- Thank you received: 2081
30 Dec 2020 08:25 #193500
by phillc54
It is a Qtvcp ActionButton.
Replied by phillc54 on topic ESTOP button behavior
I need more info.
Is the gui estop a check button or momentary?
It is a Qtvcp ActionButton.
The following user(s) said Thank You: snowgoer540
Please Log in or Create an account to join the conversation.
- snowgoer540
- Topic Author
- Offline
- Moderator
Less
More
- Posts: 2394
- Thank you received: 782
02 Jan 2021 04:51 #193802
by snowgoer540
Replied by snowgoer540 on topic ESTOP button behavior
I just wanted to see if you've had a chance to delve into the hardware handshake, etc. at all. Also see if there's anything you need from me/something I might test for you?
Please Log in or Create an account to join the conversation.
- cmorley
- Offline
- Moderator
Less
More
- Posts: 7760
- Thank you received: 2055
02 Jan 2021 06:03 #193805
by cmorley
Replied by cmorley on topic ESTOP button behavior
i looked at it - got discouraged and worked on something hard so now it will seem easy
Sorry i didn;t get back to it sooner...
Sorry i didn;t get back to it sooner...
Please Log in or Create an account to join the conversation.
- snowgoer540
- Topic Author
- Offline
- Moderator
Less
More
- Posts: 2394
- Thank you received: 782
02 Jan 2021 06:07 #193806
by snowgoer540
Haha so if I stick with trying to code long enough you’re telling me there’s a point when things will seem easy??
Breaking it seems easier though
Replied by snowgoer540 on topic ESTOP button behavior
so now it will seem easy
Haha so if I stick with trying to code long enough you’re telling me there’s a point when things will seem easy??
Breaking it seems easier though
Please Log in or Create an account to join the conversation.
- cmorley
- Offline
- Moderator
Less
More
- Posts: 7760
- Thank you received: 2055
02 Jan 2021 06:13 #193808
by cmorley
We all have our strengths....
fixing is more satisfying
Replied by cmorley on topic ESTOP button behavior
Breaking it seems easier though
We all have our strengths....
fixing is more satisfying
Please Log in or Create an account to join the conversation.
- snowgoer540
- Topic Author
- Offline
- Moderator
Less
More
- Posts: 2394
- Thank you received: 782
02 Jan 2021 06:16 #193809
by snowgoer540
Well, I can agree that I do feel like a wizard when I mess with it long enough and it does what it’s supposed to.
But I’m far better at finding the things it shouldn’t do. Still some satisfaction in helping make it better for the next guy.
Replied by snowgoer540 on topic ESTOP button behavior
Breaking it seems easier though
We all have our strengths....
fixing is more satisfying
Well, I can agree that I do feel like a wizard when I mess with it long enough and it does what it’s supposed to.
But I’m far better at finding the things it shouldn’t do. Still some satisfaction in helping make it better for the next guy.
Please Log in or Create an account to join the conversation.
Moderators: cmorley
Time to create page: 0.070 seconds