Error message when closing qtplasmac

paulsao wrote:

Qtplasmac works fine, the only thing that happens is that when closing I get that error message, I didn't have it until yesterday morning .

I see what you are talking about in my terminal as well with both package and run in place.

I do know that Chris was working on some stuff to prevent segfaults. I wonder if this is related.

I think I will move this thread over to QTVCP so he sees is, unless someone objects?

Actually, it looks like maybe its from a debug print left in. 

Let me see if I can track it down...

EDIT:  It is from this commit:  github.com/LinuxCNC/linuxcnc/commit/5d05...80a914ca8d6881a8e4a1

Prior to that commit I get no "error" on shutdown in the terminal, after that, I get the following:
Running Buster 10 (MX Linux 19.4)

Moved the thread to qtvcp so Chris would see it

cmorley wrote:

I'm stumped on how to fix this.
There isn't really an error (well in this case I'm assuming it's the usual segfault).
It is known problem with pyqt, that seems to be in this case sensitive to exiting HAL (which is the part I added back)

I'm open to ideas from coding experts.
Chris

I'm a bit confused since normally the segfault "errors" show up on versions greater than Buster.

Both paulsao and I are running Buster, which seemed to be previously immune from this (I thought anyways).

Otherwise, I am out of ideas, it's probably way above my pay grade.

Maybe this wasn't above my pay grade after all... 

Made some headway, Chris pushed this fix: github.com/LinuxCNC/linuxcnc/commit/4683...968022550a6395c38ff4

Should be improved, but report back if it isnt! 

rodw wrote:

I can't see anything has changed in that commit. All I could see was an additional logging call.

It's at the very bottom. Changed sys.exit(_qtvcp) to sys.exit(_app)

github.com/LinuxCNC/linuxcnc/blob/8890c4.../qtvcp/qtvcp.py#L509

what does LOG.debug do?

Line 427: LOG.debug('Exiting HAL')

It passes the string following it ('Exiting HAL') to the logger at the level indicated (debug in this case, the levels are: debug, info, warning, error, critical, verbose).

Worth noting - the default level is "warning", so you will only see log messages at warning level and above in the terminal. If you want to see lower than that, you can use a one of the options that is set in the display section of the ini file after "qtvcp".

DISPLAY = qtvcp -d qtplasmac

Would set logging to the debug level for qtplasmac.