Arduino IO Expansion
- AlexMagToast
-
Topic Author
- Offline
- Premium Member
-
Less
More
- Posts: 86
- Thank you received: 66
05 Mar 2024 23:14 #295268
by AlexMagToast
Replied by AlexMagToast on topic Arduino IO Expansion
Can you please try the ino File I send you in the attachments?
Please Log in or Create an account to join the conversation.
06 Mar 2024 01:02 #295275
by blazini36
Replied by blazini36 on topic Arduino IO Expansion
Found an issue @ line 455. Looks like:
should have been
Now the key matrix works as expected, no more rapid prints or duplicated M#s, the keys increment left to right and the next row starts next key. It didn't fix the LED issue, I've got a friend hunting that down. Trying to figure out if this is correct, lines 949-961
(LedGndPins[currentLED%numVccPins] looks like it should be (LedGndPins[currentLED%numGndPins] but simply changing those lines did not fix it.
keys[row][col] = row * numRows + col;should have been
keys[row][col] = row * numCols + col;Now the key matrix works as expected, no more rapid prints or duplicated M#s, the keys increment left to right and the next row starts next key. It didn't fix the LED issue, I've got a friend hunting that down. Trying to figure out if this is correct, lines 949-961
for(currentLED = 0; currentLED < numVccPins*numGndPins ;currentLED ++){
if(ledStates[currentLED] == 1){ //only handle turned on LEDs
digitalWrite(LedVccPins[currentLED/numVccPins],HIGH); //turn current LED on
digitalWrite(LedGndPins[currentLED%numVccPins],LOW);
Serial.print("VCC: ");
Serial.print(LedVccPins[currentLED/numVccPins]);
Serial.print(" GND: ");
Serial.println(LedGndPins[currentLED%numVccPins]);
delayMicroseconds(interval); //wait couple ms
digitalWrite(LedVccPins[currentLED/numVccPins],LOW); //turn off and go to next one
digitalWrite(LedGndPins[currentLED%numVccPins],HIGH);(LedGndPins[currentLED%numVccPins] looks like it should be (LedGndPins[currentLED%numGndPins] but simply changing those lines did not fix it.
Please Log in or Create an account to join the conversation.
06 Mar 2024 01:09 - 06 Mar 2024 01:29 #295276
by blazini36
I tried that file as it is, didn't do anything, doesn't print VCC and GND so I think it's not actually setting pins. I see what you were trying to do by tricking it into thinking there were 8 LEDrow pins so I corrected the LedGndPins and used the 4 correct LedRowPins + 4 unused pins to total 8 LedRowPins. Doesn't do anything either.
Replied by blazini36 on topic Arduino IO Expansion
That file is has different pin numbers that are not part of my keyboard for LedGndPins, am I supposed to change something?Can you please try the ino File I send you in the attachments?
I tried that file as it is, didn't do anything, doesn't print VCC and GND so I think it's not actually setting pins. I see what you were trying to do by tricking it into thinking there were 8 LEDrow pins so I corrected the LedGndPins and used the 4 correct LedRowPins + 4 unused pins to total 8 LedRowPins. Doesn't do anything either.
Last edit: 06 Mar 2024 01:29 by blazini36.
Please Log in or Create an account to join the conversation.
06 Mar 2024 04:19 #295288
by blazini36
Replied by blazini36 on topic Arduino IO Expansion
OK so me and a friend got this LED thing figured out. It was exactly what I said before, what I didn't realize is that the uncommented prints between lines 953 and 958 were clogging the pipe everytime an LED was set. My friend will make a PR tomorrow but this:
Line 455 fixes the key matrix
and this between Line 949 and 963 fixes the LED matrix
Line 455 fixes the key matrix
keys[row][col] = row * numCols + col;and this between Line 949 and 963 fixes the LED matrix
for(currentLED = 0; currentLED < numVccPins*numGndPins ;currentLED ++){
if(ledStates[currentLED] == 1){ //only handle turned on LEDs
digitalWrite(LedVccPins[currentLED/numVccPins],HIGH); //turn current LED on
digitalWrite(LedGndPins[currentLED%numGndPins],LOW);
/*
Serial.print("VCC: ");
Serial.print(LedVccPins[currentLED/numVccPins]);
Serial.print(" GND: ");
Serial.println(LedGndPins[currentLED/numGndPins]);
*/
delayMicroseconds(interval); //wait couple ms
digitalWrite(LedVccPins[currentLED/numVccPins],LOW); //turn off and go to next one
digitalWrite(LedGndPins[currentLED%numGndPins],HIGH);
}
}Please Log in or Create an account to join the conversation.
- AlexMagToast
-
Topic Author
- Offline
- Premium Member
-
Less
More
- Posts: 86
- Thank you received: 66
06 Mar 2024 22:19 #295357
by AlexMagToast
Replied by AlexMagToast on topic Arduino IO Expansion
glad you have figured it out. Obviously I have forgotten to edit these Serial prints out, since they are for debugging only.
I'll test your suggestion and update it accordingly.
Does the keyboard and LEDs work now?
I'll test your suggestion and update it accordingly.
Does the keyboard and LEDs work now?
Please Log in or Create an account to join the conversation.
06 Mar 2024 23:49 #295364
by blazini36
There should be some further improvements to the keypad code. If you hit 2 keys at once, accidentally or otherwise it winds up activating about 6 or so key inputs. That's probably just how the electrical paths work but the firmware should do something to disregard the errored key inputs. Once these key errors activate they also do not self-reset, they will stay active until you press that key.
I'll mention these to my friend, maybe he can find more time to help. I'm also thinking of doing a version that just uses I2C for the keypad as that should avoid any issues with multiple key presses and avoid the LED dimming that happens when the key pins switch from outputs to inputs. I wanted to use a Teensy initially but went with a Mega because of the lack of pins on the Teensy 4.1 and the lower voltage/current. I can get around much of that by just using I2C expanders on the keypad.
Replied by blazini36 on topic Arduino IO Expansion
Yes, keypad and LEDs work as expected and it seems to be working well in HAL. My friend has created the PR on the git.glad you have figured it out. Obviously I have forgotten to edit these Serial prints out, since they are for debugging only.
I'll test your suggestion and update it accordingly.
Does the keyboard and LEDs work now?
There should be some further improvements to the keypad code. If you hit 2 keys at once, accidentally or otherwise it winds up activating about 6 or so key inputs. That's probably just how the electrical paths work but the firmware should do something to disregard the errored key inputs. Once these key errors activate they also do not self-reset, they will stay active until you press that key.
I'll mention these to my friend, maybe he can find more time to help. I'm also thinking of doing a version that just uses I2C for the keypad as that should avoid any issues with multiple key presses and avoid the LED dimming that happens when the key pins switch from outputs to inputs. I wanted to use a Teensy initially but went with a Mega because of the lack of pins on the Teensy 4.1 and the lower voltage/current. I can get around much of that by just using I2C expanders on the keypad.
Please Log in or Create an account to join the conversation.
22 Apr 2024 07:58 - 22 Apr 2024 07:59 #298820
by Mr. Mass
Replied by Mr. Mass on topic Arduino IO Expansion
Great work, thanks for sharing.
Planning to use this in my next machine. Made a small test bench for training so far. I was able to set up almost all the functions I needed, but had a issue with one. It's about the encoder that works in mode 1. In the Arduino IDE in the monitor everything works as it should, but not in LinuxCNC. It practically does not react to the encoder rotation, it is possible to change the value after 20-30 positions of the encoder itself. Maybe I missed something or configured incorrectly? Here is a small video with this issue.
Planning to use this in my next machine. Made a small test bench for training so far. I was able to set up almost all the functions I needed, but had a issue with one. It's about the encoder that works in mode 1. In the Arduino IDE in the monitor everything works as it should, but not in LinuxCNC. It practically does not react to the encoder rotation, it is possible to change the value after 20-30 positions of the encoder itself. Maybe I missed something or configured incorrectly? Here is a small video with this issue.
Last edit: 22 Apr 2024 07:59 by Mr. Mass.
Please Log in or Create an account to join the conversation.
Time to create page: 0.082 seconds