- Posts: 22
- Thank you received: 240
Arc Tolerance
- ArcEye
- Offline
- Junior Member
-
Less
More
11 years 10 months ago - 11 years 10 months ago #54230
by ArcEye
Replied by ArcEye on topic Arc Tolerance
I didn't end up with much time for testing.
The patch has an error which probably does not need explanation
It did not patch successfully on fresh pull of the master, not quite sure which version Dewey patched against, some of the line numbers do not match.
EDIT: Now read your post properly and see he has patched 2.7, not 2.8 (ie master).
All starting to get a bit complicated with a 2.7 alpha and a 2.8 master existing at the same time :laugh:
I manually inserted the lines and started to hit strange problems, but ran out of time to debug it.
Will look at it again tomorrow.
regards
The patch has an error which probably does not need explanation
Code:
--- a/src/emc/rs274ngc/rs274ngc_pre.cc
+++ b/src/emc/rs274ngc/rs274ngc_pre.cc
@@ -966,6 +966,11 @@ int Interp::init()
n++;
}
+ _setup.tolerance_inch = TOLERANCE_INCH;
+ _setup.tolerance_mm = TOLERANCE_INCH;
+ inifile.Find(&_setup.tolerance_inch, "TOLERANCE_INCH", "RS274NGC");
+ inifile.Find(&_setup.tolerance_mm, "TOLERANCE_MM", "RS274NGC");
+
// close it
inifile.Close();
}
--
1.7.10.4
It did not patch successfully on fresh pull of the master, not quite sure which version Dewey patched against, some of the line numbers do not match.
EDIT: Now read your post properly and see he has patched 2.7, not 2.8 (ie master).
All starting to get a bit complicated with a 2.7 alpha and a 2.8 master existing at the same time :laugh:
I manually inserted the lines and started to hit strange problems, but ran out of time to debug it.
Will look at it again tomorrow.
regards
Last edit: 11 years 10 months ago by ArcEye.
Please Log in or Create an account to join the conversation.
- BigJohnT
- Offline
- Administrator
-
Less
More
- Posts: 3981
- Thank you received: 994
11 years 10 months ago #54232
by BigJohnT
Replied by BigJohnT on topic Arc Tolerance
Sorry I forgot to mention is it a patch against 2.7... there is quite a discussion going on on the IRC devel channel today about this.
JT
JT
Please Log in or Create an account to join the conversation.
- ArcEye
- Offline
- Junior Member
-
Less
More
- Posts: 22
- Thank you received: 240
11 years 10 months ago #54258
by ArcEye
Replied by ArcEye on topic Arc Tolerance
Hi
This is a patch made and tested against master (2.8 ~pre)
It is not exhaustively tested, the MAX values are arbitrary ones (but equivalent to each other) based upon what allowed the sample code to be run.
It allows the ini file fields Dewey set of
[RS274NGC]
TOLERANCE_INCH =
TOLERANCE_MM =
to control the arc tolerance used
Entries in src/emc/rs274ngc/interp_internal.hh
have corrected value for metric tolerance and new #define s of MAX_TOLERANCE_INCH / MAX_TOLERANCE_MM to impose a limit upon how loose the tolerance can be set
src/emc/rs274ngc/rs274ngc_pre.cc
now does the checking and sets top and bottom tolerance values if the ini file figures exceed them
I can submit this or leave Dewey to adapt as he pleases and do it himself (probably easier as he has push rights anyway)
regards
This is a patch made and tested against master (2.8 ~pre)
It is not exhaustively tested, the MAX values are arbitrary ones (but equivalent to each other) based upon what allowed the sample code to be run.
It allows the ini file fields Dewey set of
[RS274NGC]
TOLERANCE_INCH =
TOLERANCE_MM =
to control the arc tolerance used
Entries in src/emc/rs274ngc/interp_internal.hh
have corrected value for metric tolerance and new #define s of MAX_TOLERANCE_INCH / MAX_TOLERANCE_MM to impose a limit upon how loose the tolerance can be set
src/emc/rs274ngc/rs274ngc_pre.cc
now does the checking and sets top and bottom tolerance values if the ini file figures exceed them
I can submit this or leave Dewey to adapt as he pleases and do it himself (probably easier as he has push rights anyway)
regards
Please Log in or Create an account to join the conversation.
- BigJohnT
- Offline
- Administrator
-
Less
More
- Posts: 3981
- Thank you received: 994
11 years 10 months ago #54260
by BigJohnT
Replied by BigJohnT on topic Arc Tolerance
Just my humble opinion but I think this should go in 2.7 as it fixes a long standing error in the code with mismatched tolerance for arcs.
JT
JT
Please Log in or Create an account to join the conversation.
- ArcEye
- Offline
- Junior Member
-
Less
More
- Posts: 22
- Thank you received: 240
11 years 10 months ago #54262
by ArcEye
I am quite happy to do a patch for 2.7 too
Don't know where it is located however, I thought they were branches on linuxcnc.git, but the clone I made only has the one branch, master.
Replied by ArcEye on topic Arc Tolerance
BigJohnT wrote: Just my humble opinion but I think this should go in 2.7 as it fixes a long standing error in the code with mismatched tolerance for arcs.
JT
I am quite happy to do a patch for 2.7 too
Don't know where it is located however, I thought they were branches on linuxcnc.git, but the clone I made only has the one branch, master.
Please Log in or Create an account to join the conversation.
- BigJohnT
- Offline
- Administrator
-
Less
More
- Posts: 3981
- Thank you received: 994
11 years 10 months ago #54263
by BigJohnT
Replied by BigJohnT on topic Arc Tolerance
To get a branch just do:
git checkout branch_name
The naming for branches from 2.6 and up is just 2.6 and 2.7. They used to be a convoluted v2.4_branch.
To list all branches do:
git branch -r
Wow there is a lot of branches!
JT
git checkout branch_name
The naming for branches from 2.6 and up is just 2.6 and 2.7. They used to be a convoluted v2.4_branch.
To list all branches do:
git branch -r
Wow there is a lot of branches!
JT
Please Log in or Create an account to join the conversation.
Time to create page: 0.587 seconds