Materialverter
06 Jul 2020 22:26 - 06 Jul 2020 22:36 #173776
by snowgoer540
Materialverter was created by snowgoer540
Used the materialverter for the first time today, from Sheetcam. Everything worked great, except for one small detail, I had the Cut Mode set as 2 for all of my materials, and it didn't pick that up, they were all at Cut Mode = 1 after the conversion. So, I proposed the fix on github. Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems... I'm proposing solutions 
. 
Just in case you want any code to test the fix (it works on my end)...
Input Example:
Output Example (before fix):
Output Example (after fix):
First HAL, now Github changes... wonder what's next!?
EDIT: I am 99% sure I proposed the changes correctly on github. If I didnt, and I need to do it some other way, please let me know. Also, if you prefer I suggest changes here instead, let me know that as well.
. Just in case you want any code to test the fix (it works on my end)...
Input Example:
[Tool0]
Type=PlasmaTool
Name=65A Steel 10GA Best
Comment=
Tool\ number=1
Kerf\ width=1.651
Plunge\ rate=0
Pierce\ delay=0.1
Pause\ at\ end\ of\ cut=0
Wiggle\ length=9.999979999999999
Pierce\ height=3.81
Cut\ height=1.524
Pierce\ type=0
Feed\ rate=4826
Lead\ in=0
Lead\ out=0
Lead\ in\ type=0
Lead\ out\ type=0
CodeSnip=-1
Hole\ Size=0
Use\ leadin\ settings=0
[Tool0/Custom]
Puddle\ jump\ height=0
Puddle\ jump\ delay=0
THC\ enable=1
Cut\ voltage=125
Cut\ current=65
Gas\ pressure=0
Cut\ mode=2Output Example (before fix):
[MATERIAL_NUMBER_1]
NAME = 65A Steel 10GA Best
KERF_WIDTH = 0.065
THC = 1
PIERCE_HEIGHT = 0.150
PIERCE_DELAY = 0.1
PUDDLE_JUMP_HEIGHT = 0
PUDDLE_JUMP_DELAY = 0
CUT_HEIGHT = 0.060
CUT_SPEED = 190
CUT_AMPS = 65
CUT_VOLTS = 125
PAUSE_AT_END = 0
GAS_PRESSURE = 0
CUT_MODE = 1Output Example (after fix):
[MATERIAL_NUMBER_1]
NAME = 65A Steel 10GA Best
KERF_WIDTH = 0.065
THC = 1
PIERCE_HEIGHT = 0.150
PIERCE_DELAY = 0.1
PUDDLE_JUMP_HEIGHT = 0
PUDDLE_JUMP_DELAY = 0
CUT_HEIGHT = 0.060
CUT_SPEED = 190
CUT_AMPS = 65
CUT_VOLTS = 125
PAUSE_AT_END = 0
GAS_PRESSURE = 0
CUT_MODE = 2First HAL, now Github changes... wonder what's next!?
EDIT: I am 99% sure I proposed the changes correctly on github. If I didnt, and I need to do it some other way, please let me know. Also, if you prefer I suggest changes here instead, let me know that as well.
Please Log in or Create an account to join the conversation.
06 Jul 2020 22:30 #173777
by thefabricator03
You need to stop that, your making the rest of us look bad
Replied by thefabricator03 on topic Materialverter
Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems...
You need to stop that, your making the rest of us look bad
Please Log in or Create an account to join the conversation.
06 Jul 2020 22:31 #173778
by snowgoer540
Haha, well hopefully it's not a 1 hit wonder.
Replied by snowgoer540 on topic Materialverter
Yep, you read that correctly. I'm officially contributing to the code, no longer just finding problems...
You need to stop that, your making the rest of us look bad
Haha, well hopefully it's not a 1 hit wonder.
Please Log in or Create an account to join the conversation.
07 Jul 2020 00:14 #173786
by snowgoer540
Well, on the bright side, something you dont have to spend time fixing In all reality, I just plagiarized what was there, and changed variable names. I couldnt write that code outright.
Ok, other than the additions to the files, did I do everything else correctly? Am I supposed to start a pull request to linuxcnc? I'm a bitt miffed about how it actually gets into the next update...
Do you want me to make the aforementioned changes to the other 3 files?
Replied by snowgoer540 on topic Materialverter
Thanks for that, something else I missed.
A couple of additions are required to bring the version number up to date:
in the same directory:
plasmac_config.py - line 324 - new version and date
version.html - line 22 - create a new version and date block
in linuxcnc-dev/src/hal/components:
plasmac.comp - line 10 - new version and date
Maybe I should put a sticky thread describing this in case others want to contribute code.
Well, on the bright side, something you dont have to spend time fixing
In all reality, I just plagiarized what was there, and changed variable names. I couldnt write that code outright.Ok, other than the additions to the files, did I do everything else correctly? Am I supposed to start a pull request to linuxcnc? I'm a bitt miffed about how it actually gets into the next update...
Do you want me to make the aforementioned changes to the other 3 files?
Please Log in or Create an account to join the conversation.
07 Jul 2020 00:22 #173788
by phillc54
Replied by phillc54 on topic Materialverter
Well you found where the problem was and that is half the battle.Well, on the bright side, something you dont have to spend time fixing
Yeah, you can do it that way, it is a good way to contribute. The PR's get manually merged by whoever thinks they should be merged.Ok, other than the additions to the files, did I do everything else correctly? Am I supposed to start a pull request to linuxcnc? I'm a bitt miffed about how it actually gets into the next update...
Yeah, if you want to complete the commit and get it merged.Do you want me to make the aforementioned changes to the other 3 files?
Please Log in or Create an account to join the conversation.
Moderators: snowgoer540
Time to create page: 0.107 seconds