Materialverter

More
07 Jul 2020 01:10 #173794 by snowgoer540
Replied by snowgoer540 on topic Materialverter
Ok, I think I got it figured out. I am doing this from the website btw, idk if that makes a difference.

There is no linuxcnc-dev that I see on the github repository. I changed the .comp file under the linuxcnc folder. I am not sure if that was right or not, you can see what I did there though, please let me know if I need to fix it.

How does this get from the master branch to the 2.8 branch? It looks like everything I did was under master?

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:11 #173795 by snowgoer540
Replied by snowgoer540 on topic Materialverter

Maybe I should put a sticky thread describing this in case others want to contribute code.


I think a sticky is probably a good idea?

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:17 #173796 by phillc54
Replied by phillc54 on topic Materialverter
OK, I assumed you were doing it from your local repo.
It does all need to be in one commit though, which you can do locally with a squash. I am not sure how that can be achieved via the website.
It may be worthwhile asking the question on the developers email list:
sourceforge.net/projects/emc/lists/emc-developers

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:18 #173797 by snowgoer540
Replied by snowgoer540 on topic Materialverter

OK, I assumed you were doing it from your local repo.
It does all need to be in one commit though, which you can do locally with a squash. I am not sure how that can be achieved via the website.
It may be worthwhile asking the question on the developers email list:
sourceforge.net/projects/emc/lists/emc-developers


I think I got them all to the same pull request, does it look right, or no?

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:20 #173798 by phillc54
Replied by phillc54 on topic Materialverter
They are the same PR but there are four commits, ideally it should be one.
The following user(s) said Thank You: snowgoer540

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:38 #173800 by snowgoer540
Replied by snowgoer540 on topic Materialverter
I don't think I have the permissions I need from what I see on the interwebs. At any rate, I've reached the max amount of frustration for the evening, and ironically the end of my laptop battery.
                    elif line.startswith('Cut\ mode') or (line.startswith('Preset\ mode') and self.materialCutM == 'CUT_MODE           = 1'):
                        a,b = line.split('=',1)
                        self.materialCutM = 'CUT_MODE           = {}'.format(b.strip())

needs to be inserted after line 306, or as the screen shot shows:



Evidently I can only have one coding victory per day.

It wont hurt my feelings if you commit the change on my behalf. I'll figure out git another day.
Attachments:

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:45 #173803 by phillc54
Replied by phillc54 on topic Materialverter
If you do want to try again here is a starting point. I can help you through if I know the answers.

linuxcnc.org/docs/html/code/contributing-to-linuxcnc.html

No rush, you can always close the existing PR and make a new one when you a happy with what you have.

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 01:59 #173804 by snowgoer540
Replied by snowgoer540 on topic Materialverter

If you do want to try again here is a starting point. I can help you through if I know the answers.

linuxcnc.org/docs/html/code/contributing-to-linuxcnc.html

No rush, you can always close the existing PR and make a new one when you a happy with what you have.


Ah, yea that seems like a good place to start. Maybe I dont have my profile filled out right... I’ll close the pull request in the morning and try to start again but from the Linux pc. Seems git is happier with terminal commands?

At any rate the lappy is charging, I’ll go at it fresh tomorrow. Thanks as usual!

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 02:00 #173805 by phillc54
Replied by phillc54 on topic Materialverter
No worries, its a good learning experience.

Please Log in or Create an account to join the conversation.

More
07 Jul 2020 12:09 #173825 by rodw
Replied by rodw on topic Materialverter
Awesome work Snowgoer, a real pro now!

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.168 seconds
Powered by Kunena Forum