Inssues Hole cutting

More
07 May 2024 23:07 #300076 by tommylight
Replied by tommylight on topic Inssues Hole cutting
Had a play with this, Axis metric sim shows same behavior, goes through arcs only on all 3.
Probably because both G3 lines have the same starting point so nothing to move to, despite different I and J values.
Changing the G0 value changes the result, as it also moves the end point of the first G3 line, so it has where to move to.
Changing the first G3 line X by 0.001 below makes everything work properly, while changing it by 0.001mm above will completely erase the circle. The opposite is true for Y value.
Replacing G3 with G2 in any line works as expected, so does replacing both.
The following user(s) said Thank You: snowgoer540

Please Log in or Create an account to join the conversation.

More
07 May 2024 23:57 - 08 May 2024 00:00 #300080 by snowgoer540
Replied by snowgoer540 on topic Inssues Hole cutting
Thanks Tommy.

I do believe this is an issue with the "FUZZ" values not changing with the machine units.

If I import stdio.h into _posemath.c and add a print statement after the line Phill changed in the previous commit (approx line 1851), to print "d", when I run the file, I get the following results...

IMPERIAL CONFIG:

-0.00000000000000054123
-0.00000000000000013357
0.00000000000000018041
-0.00000000000000054123


METRIC CONFIG:

Nothing.  The line is never reached because d is not < DOUBLE_FUZZ.

However, if I change the line to compare against CART_FUZZ I get:

0.00000000000010924595
-0.00000039177040989102
0.00000000000003641532
-0.00000039177033173132
0.00000000000010924595
-0.00000039177054844686


The other circle check around line 1862 uses CART_FUZZ as well, so I think changing line 1851 to be the correct route of action...
Last edit: 08 May 2024 00:00 by snowgoer540.
The following user(s) said Thank You: tommylight, paulsao

Please Log in or Create an account to join the conversation.

More
08 May 2024 00:21 #300081 by tommylight
Replied by tommylight on topic Inssues Hole cutting
Wait, if G2 works but G3 does not, is there something different for those two in code? I mean except the left-right side.
Need sleep badly...
The following user(s) said Thank You: paulsao

Please Log in or Create an account to join the conversation.

More
10 May 2024 15:34 #300331 by snowgoer540
Replied by snowgoer540 on topic Inssues Hole cutting
I pushed a fix for this to both 2.9 and master.  

You should be able to update after the buildbots do their thing.
The following user(s) said Thank You: tommylight, paulsao

Please Log in or Create an account to join the conversation.

More
10 May 2024 20:24 #300341 by paulsao
Replied by paulsao on topic Inssues Hole cutting
Thank you very much for following up on the problem. Maybe one day I can replace my plasma with a laser machine. I see there are some advances on that.

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.184 seconds
Powered by Kunena Forum