Cut Recovery Not Consistently Triggering

More
1 year 9 months ago #317900 by phillc54
It appears to have been caused by this commit  in July which seems to affect the HAL Python module.
It only affects locales that use commas instead of periods in floating point numbers.

A workaround until we get a permanent solution would be to edit src/emc/rs274ngc/interp_internal.hh and change the following:

Line 998 from:
       
Code:
~scoped_locale() { setlocale(category, oldlocale.c_str()); }
to:
     
Code:
 ~scoped_locale() { setlocale(category, oldlocale); }

Line 1000 from:
   
Code:
 std::string oldlocale;
to:
   
Code:
const char *oldlocale;
and then recompile.
The following user(s) said Thank You: gekonko

Please Log in or Create an account to join the conversation.

More
1 year 9 months ago #318083 by gekonko
thank you again @phillc54,
your first post led me to realisation, i was running master branch, and not v2.9.3..
at this point, I did:
-make clean
-deleted whole folder linuxcnc-dev
-git clone
-git checkout tags/v2.9.3
and rest was just RIP install

Please Log in or Create an account to join the conversation.

More
1 year 9 months ago #318125 by phillc54
That would be a safe option for the time being as 2.9 is unaffected by this issue.

I have opened an issue  on GitHub.
 
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
1 year 9 months ago #318365 by phillc54
This should now be fixed:
github.com/LinuxCNC/linuxcnc/commit/5928...ae29d5ddb741c6456856

Although if you are using Bookworm and relying on buildbot2 then you will need to wait until it begins build again, the latest there is 24 Oct.
buildbot2.highlab.com/debian/dists/bookw...inary-amd64/?C=M;O=D
 

Please Log in or Create an account to join the conversation.

More
1 year 9 months ago #318561 by Franklin
I updated with buildbot2 today and Cut Recovery is working again. Thanks.
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.069 seconds
Powered by Kunena Forum