gmocappy clock

@Hans,

I like the option you choose without the hal pins, as it makes it easier for users, as you mentioned.

I have some points to criticize:
- Take your code an run gmoccapy_2_tools_with_cutter_radius_compensation.ngc from nc_files
You will note, that this sample program has an optional stop. After you resume from pause you will note, that the time will not increase any more, as the interpreter did read already the complete code.
- You missed to add the code to set the styling of the panel to be the same as the one gmoccapy uses. It is only an optical aspect, but does not look good. I use Clearlooks as Theme for my gmoccapy.

I changed a litel bit your code, please test with your program where you stopped from pause, IMHO my way it is doing what it should.
(Attention I changed "-" to "_" in the file name to distinguish them)

And we would like to add also a part counter, to indicate 11 parts made

Thank you so much for your support to develop gmoccapy, also for the ones you mentioned in Github, I need to check the code and your proposals as soon as possible.

Norbert

@Norbert

Thanks for you comments.
A good idea to reset the Program Running Counter on start button instead of on stop button.
I found a better way to handle the running state even with optional stop. Just accessing the value of halui.program.is-running instead of the interpreter signal as it fits not so good for this.

• So I eliminated all pins that could also be accessed internally.
  
• I fixed the calculation of the minutes value.
  
• And of course I added the Parts Counter. It is currently shown in the settings area. May someone wants to have it at another place, I don't know as I don't need it.

@Hans,

you fixed the minutes calculation, that's fine, I did not test the calculation with 4000 Seconds, so I did not note that bug, shame on me. But whx did you correct the error only in one python file?

IMHO we Don not need any more the handler files for PAUSED or IDLE, so why not delete them?

Norbert

newbynobi wrote:
you fixed the minutes calculation, that's fine, I did not test the calculation with 4000 Seconds, so I did not note that bug, shame on me. But whx did you correct the error only in one python file?

That there is something left for you to fix

newbynobi wrote:
IMHO we Don not need any more the handler files for PAUSED or IDLE, so why not delete them?

Just for debugging, of course they can be removed.

@hansu

Wo kommst du her? Ich wohne in der Nähe von Hildesheim

Norbert

@Norbert
Ich wohne aktuell in Berlin...

Hans