Orient component revised

Well,

Yes i actually use a muxed signal for enable the drive and the same connected to pendant for spindle status.

Mostly regarding the HAL status with orient activated the built in "halui.spindle.0.on" "spindle.0.on" seem to be strange to see as False.

If you think all is ok as it is : i understand and other connection is possible.

Br

andypugh wrote:

It's one of those things that could be argued either way.

This is the reason for my message, i'm really unsure but in my opinion this need to be done for possible safety issue.
Unfortunately i haven't many arguments and i'm sure your decision was the good one regarding to this.

Br

First attempt for add a MPG/pendant jog mode

ultra basic send counts value to asked angle without checking the scale (more work is needed)

Not fully tested but i'm open for any suggestion.

If someone using the original component can test this one for feedback it be marvellous !

Br

Hi

Now jog mode use scale

TODO better management for enable spindle from pendant

Well i really like testing from experimented user !

I have now do auto homing orient by index-enable automatically after machine is homed, or at first M19, or at first M3/M4

Jog work but is not perfect, i need to found a way for prevent moving if wheel is rotated before spindle homing and you do homing and enable_from_jog is already actived or later .

I have add some pin for display text message using link to MDI_COMMAND, but maybee they are better way to do this.

github.com/LinuxCNC/linuxcnc/issues/725

andypugh wrote:

I can see that you might expect M19 to set spindle-on, but it seems that it doesn't. It's one of those things that could be argued either way.

In fact spindle-on only goes true after M3 / M4 _and_ when S > 0

does this mean you must have the spindle rotating already to orient?
Another reason to not require S = 0 to turn off the spindle.

Chris

Hi

The orient process is standalone, and do not use the traditional spindle hal signal.
But imo i think strange to not see spindle status on with "halui.spindle.0.on" "spindle.0.on" using orient

For now using orient yes S=0 but "halui.spindle.0.on" "spindle.0.on" = off

Br

I think we should require that spindle be on to orient.
I don't think we should require the spindle to be spinning to have the spindle on.
I don't think we should require that the spindle be already spinning to orient.