qtdragon - probing issues

Ok Versby seems unchanged from prior behaviour

Basic Probe incorrectly finishes at z clearance + extra depth

See attached image Z is at 13mm when it should (and was previously) be 10mm
 
You need the extra depth becasue if you probe to surface and finishes at Z10
on an XY corner probe the probe only decend to the surface height before probing for the material. Adding extra depth ensures the probe contacts the edge instead of potentially skimming over the top.

Because each probe routine is a python procedure, It might be possible to add a checkbox to basic probe "Probe to height first"
If set,  a corner or edge probe could probe for the height before probing for X & Y. 
That would let you zero the machine in one step (and is consistent with a normal workflow)
That would be cool!
 

So the only change I did was separate xy and z max probe distance. You can have them at different lengths.
This doesn't have anything to do with finish position.
Can you confirm that max Z is being honoured now

finish depth:
I see in the code, extra depth is always added to clearance, but when down probing I think it shouldn't. extra depth does make sense when down probing.
extra depth is to get below chamfers etc when side probing.

Does that sound right?

I pushed a change to not add extra depth to down probe.
This should fix the finish position to be Z clearance when finished.

cmorley wrote:

finish depth:
I see in the code, extra depth is always added to clearance, but when down probing I think it shouldn't. extra depth does make sense when down probing.
extra depth is to get below chamfers etc when side probing.

Does that sound right?

Yes I reckon you got it right. I guess on a side probe it has to lift up from it's position by extra_depth + clearance height to get to the finish (clearance height)

But on a straight down Z probe, it is already at surface height when the probe triggers so it just needs to lift by clearance height. 

I think if the extra height adjustment has been removed from the Z probe, it's safe to push it to 2.9 branch now.

It will be a while before I'm back at work again.. Might not be until Monday (your Tuesday).

Great to have nailed one more bug! Thanks for being so responsive!

could not help myself. Went back to work. Now working wit h flying colours.
Where is the .ui file for the basic probe panel?

share/qtvcp/widget_ui

github.com/LinuxCNC/linuxcnc/tree/master/share/qtvcp/widgets_ui

the help files re there too.