qtdragon - probing issues

I pushed a change to not add extra depth to down probe.
This should fix the finish position to be Z clearance when finished.

cmorley wrote:

finish depth:
I see in the code, extra depth is always added to clearance, but when down probing I think it shouldn't. extra depth does make sense when down probing.
extra depth is to get below chamfers etc when side probing.

Does that sound right?

Yes I reckon you got it right. I guess on a side probe it has to lift up from it's position by extra_depth + clearance height to get to the finish (clearance height)

But on a straight down Z probe, it is already at surface height when the probe triggers so it just needs to lift by clearance height. 

I think if the extra height adjustment has been removed from the Z probe, it's safe to push it to 2.9 branch now.

It will be a while before I'm back at work again.. Might not be until Monday (your Tuesday).

Great to have nailed one more bug! Thanks for being so responsive!

could not help myself. Went back to work. Now working wit h flying colours.
Where is the .ui file for the basic probe panel?

share/qtvcp/widget_ui

github.com/LinuxCNC/linuxcnc/tree/master/share/qtvcp/widgets_ui

the help files re there too.

Can you pull again and test. added better logging and error messages
It's quite a big change so careful testing.

Nice to see qtdragon probing is getting some attention.  thanks.
found another problem, i think.   in  Versa Probe option.
seems the Outside probing of a boss (the center option on the Outside probing type page) does not report the results correctly.
See the image.
the Inside probing does report results correctly.  see the image.
I was probing the inside and outside diameters of a bearing.  first the inside, then the outside.
I looked around the best I could to find the problem, but can't tell exactly where or what it is.
I check in probe_routines.py. probe_subprog.py, and versa_probe.py.   and looked through probe ngc files......

please check it out and fix if possible.
also, what is the functional order of the code?  like when one clicks on a probe type routine, what is actually going on in the program? 
 
 

ui button sends probe function name to versa_probe.py
versa_probe sends function name/data to probe_subprogram (running as a sub process)
probe_subprogram imports probe_routines so really both files are one program.

versa 'inside hole button' calls 'probe_xy_hole' in probe_routine
probe_xy_hole does all the probe moves and calculates diameter

versa 'outside hole button' calls 'probe_outside_xy_center'
probe_outside_xy_center doesn't calculate anything it calls other separate function.

so, can the poor, incorrect reporting for the Outside pocket be fixed?
it's not 'Outside Length', it's an Outside boss.....
please?

thanks for the program functioning path....

Roguish wrote:

please check it out and fix if possible.
also, what is the functional order of the code?  like when one clicks on a probe type routine, what is actually going on in the program? 
 

 

Was that image probing for a boss or a pocket/
If a boss, why is it reporting an inside hole?

I really have not had any luck with small holes (eg 10mm). There are non-probe moves happening after the probe enters the hole that cause an error. Really there should be  no non probe moves inside  a hole.

I wonder if the boss shouldn't be using top, bottom, left and right side probing?

I pushed a hopeful fix to the feature branch above if you can test...