New pin motion.base-feedrate in master branch
23 Mar 2020 23:01 - 24 Mar 2020 03:35 #161294
by rodw
New pin motion.base-feedrate in master branch was created by rodw
Chris Morley has just released a new feature to master branch that creates a new hal pin
This pin is set by the F code sent in your Gcode so if Plasmac were to use this pin, there would be no need to pass the feedrate back to Plasmac with:
F#<_hal[plasmac.cut-feed-rate]>
I've tested this as working here this morning. For more info type man motion at the command prompt or consult the motion docs for master branch.
It just gets better and better for plasma cutting!
So Phil, time for an upgrade!
And great work Chris!
motion.base-feedrate
This pin is set by the F code sent in your Gcode so if Plasmac were to use this pin, there would be no need to pass the feedrate back to Plasmac with:
F#<_hal[plasmac.cut-feed-rate]>
I've tested this as working here this morning. For more info type man motion at the command prompt or consult the motion docs for master branch.
It just gets better and better for plasma cutting!
So Phil, time for an upgrade!
And great work Chris!
Last edit: 24 Mar 2020 03:35 by rodw.
The following user(s) said Thank You: tommylight, thefabricator03
Please Log in or Create an account to join the conversation.
23 Mar 2020 23:13 #161296
by cmorley
Replied by cmorley on topic New pin motion.requested-vel in master branch
It's not in master yet Rod ..that's a testing branch.
This does what you guys need though yes?
Do you use reverse run - I haven't tested it with reverse run.
Chris
This does what you guys need though yes?
Do you use reverse run - I haven't tested it with reverse run.
Chris
The following user(s) said Thank You: tommylight
Please Log in or Create an account to join the conversation.
23 Mar 2020 23:21 - 24 Mar 2020 03:30 #161301
by phillc54
Thanks again Chris
Replied by phillc54 on topic New pin motion.requested-vel in master branch
If it does as advertised then YES.This does what you guys need though yes?
Reverse run is used manually for error recovery so for plasma users it would not be a major concern if velocity was reported wrongly during reverse runDo you use reverse run - I haven't tested it with reverse run.
Thanks again Chris
Last edit: 24 Mar 2020 03:30 by phillc54.
The following user(s) said Thank You: tommylight, thefabricator03
Please Log in or Create an account to join the conversation.
24 Mar 2020 03:28 #161310
by rodw
Replied by rodw on topic New pin motion.requested-vel in master branch
Ooops sorry, I jumped the gun. I'm compiling Chris's test branch now...
Please Log in or Create an account to join the conversation.
24 Mar 2020 03:48 - 24 Mar 2020 03:49 #161315
by rodw
Tested and working on the Spaceship!
The only consideration is that it shows exactly what the F command is. (in my case 1425 mm/min)
Should it show feedrate per second to be consistent with all the other velocities? (eg. 1425/60 = 23.75)
How does Phill use it in Plasmac?
Replied by rodw on topic New pin motion.base-feedrate in master branch
It's not in master yet Rod ..that's a testing branch.
This does what you guys need though yes?
Do you use reverse run - I haven't tested it with reverse run.
Chris
Tested and working on the Spaceship!
The only consideration is that it shows exactly what the F command is. (in my case 1425 mm/min)
Should it show feedrate per second to be consistent with all the other velocities? (eg. 1425/60 = 23.75)
How does Phill use it in Plasmac?
Last edit: 24 Mar 2020 03:49 by rodw.
Please Log in or Create an account to join the conversation.
- thefabricator03
- Offline
- Platinum Member
Less
More
- Posts: 1130
- Thank you received: 533
24 Mar 2020 05:57 #161319
by thefabricator03
Replied by thefabricator03 on topic New pin motion.base-feedrate in master branch
Rod,
Can you explain exactly what this means for the uneducated? Is it just a cleaner way to do the same thing Phil has done?
Also what exactly is state tags again?
Can you explain exactly what this means for the uneducated? Is it just a cleaner way to do the same thing Phil has done?
Also what exactly is state tags again?
Please Log in or Create an account to join the conversation.
24 Mar 2020 06:05 #161320
by phillc54
Replied by phillc54 on topic New pin motion.base-feedrate in master branch
IMHO it is supposed to reflect what was in the GCode so it should be units/minute.The only consideration is that it shows exactly what the F command is. (in my case 1425 mm/min)
Should it show feedrate per second to be consistent with all the other velocities? (eg. 1425/60 = 23.75)
Phill doesn't even think about it until it is in master.How does Phill use it in Plasmac?
Please Log in or Create an account to join the conversation.
24 Mar 2020 06:28 #161321
by rodw
I would not say it was cleaner. It was just more comprehensive so a lot more parameters were made available. There is an experimental branch in git. I thought it was paid for by Tormach but then nobody bothered to incorporate it into the core code. It touched a lot of code but those touches was mostly adding additional messaging. So now its 5 or so years behind, maybe more.
Phill, start thinking as I think Chris should push it.
Replied by rodw on topic New pin motion.base-feedrate in master branch
Rod,
Can you explain exactly what this means for the uneducated? Is it just a cleaner way to do the same thing Phil has done?
Also what exactly is state tags again?
I would not say it was cleaner. It was just more comprehensive so a lot more parameters were made available. There is an experimental branch in git. I thought it was paid for by Tormach but then nobody bothered to incorporate it into the core code. It touched a lot of code but those touches was mostly adding additional messaging. So now its 5 or so years behind, maybe more.
Phill, start thinking as I think Chris should push it.
Please Log in or Create an account to join the conversation.
24 Mar 2020 06:50 #161322
by cmorley
Replied by cmorley on topic New pin motion.base-feedrate in master branch
yes it's in units per minute, as per the F code.
It certainly can be in units per second if that's better I suppose.
I was thinking the pin name should be changed to motion.fcode
The units can be different depending on the current units mode and axis type.
Ie if rotating its degrees per minute, if in imperial mode it's feet per minute.
That's just how gcode works, so should probably trap those things.
I quickly looked at statetags and it needs work to merge. It's surely better in the long run - I'm just not sure i'm up to the task yet and developers seemed to have dried up alot on linuxcnc...
Chris
I believe you guys use remap for this at the moment? Using this would lower the bar for users - Remap is a pain
It certainly can be in units per second if that's better I suppose.
I was thinking the pin name should be changed to motion.fcode
The units can be different depending on the current units mode and axis type.
Ie if rotating its degrees per minute, if in imperial mode it's feet per minute.
That's just how gcode works, so should probably trap those things.
I quickly looked at statetags and it needs work to merge. It's surely better in the long run - I'm just not sure i'm up to the task yet and developers seemed to have dried up alot on linuxcnc...
Chris
I believe you guys use remap for this at the moment? Using this would lower the bar for users - Remap is a pain
The following user(s) said Thank You: thefabricator03
Please Log in or Create an account to join the conversation.
24 Mar 2020 06:54 #161323
by phillc54
At the moment we read the F word from a hal pin and use the hal pin value as our target.
Replied by phillc54 on topic New pin motion.base-feedrate in master branch
No, we did use remap but as you said it is a pain so we gave it away.I believe you guys use remap for this at the moment? Using this would lower the bar for users - Remap is a pain
At the moment we read the F word from a hal pin and use the hal pin value as our target.
Please Log in or Create an account to join the conversation.
Moderators: snowgoer540
Time to create page: 0.225 seconds