New pin motion.base-feedrate in master branch

cmorley
Offline
Moderator

26 Mar 2020 16:34 #161580 by cmorley

Replied by cmorley on topic New pin motion.base-feedrate in master branch

excellent - I don't know if you got the update to AXIS to display the F code properly too.
Though I need help (Phill help please lol) to make the code display area one line deeper.
If the f code for threading is 4 decimals it pushes the text down too far.

Thanks for the feedback

Chris

The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

phillc54
Offline
Moderator

26 Mar 2020 22:39 - 26 Mar 2020 22:56 #161623 by phillc54

Replied by phillc54 on topic New pin motion.base-feedrate in master branch

cmorley wrote:
excellent - I don't know if you got the update to AXIS to display the F code properly too.
Though I need help (Phill help please lol) to make the code display area one line deeper.
If the f code for threading is 4 decimals it pushes the text down too far.

~~Where does AXIS disply the F code, I don't see it on a standard sim.~~

Edit. I saw it on the MDI tab, if that is what you mean and want an extra line:

share/axis/tcl/axis.tcl 1256

text $_tabs_mdi.gcodes \
	-height 2 \
	-width 40 \
	-undo 0 \
	-wrap word

height is the height of the box in lines.

Last edit: 26 Mar 2020 22:56 by phillc54.

Please Log in or Create an account to join the conversation.

fixer
Offline
Premium Member

26 Mar 2020 23:08 #161628 by fixer

Replied by fixer on topic New pin motion.base-feedrate in master branch

Fix for new feed signal in Gmoccapy is something like this:

-   real_feed = float(self.stat.settings[1] * self.stat.feedrate)
+  real_feed = float(self.stat.current_fcode * self.stat.feedrate)

Please Log in or Create an account to join the conversation.

cmorley
Offline
Moderator

27 Mar 2020 00:45 #161645 by cmorley

Replied by cmorley on topic New pin motion.base-feedrate in master branch

Thanks guys

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

28 Mar 2020 17:52 #161825 by andypugh

Replied by andypugh on topic New pin motion.base-feedrate in master branch

I have had a quick look at how hard it would be to merge statetags to master.

It looks doable. I wonder if it's a better idea?

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

28 Mar 2020 21:04 #161839 by andypugh

Replied by andypugh on topic New pin motion.base-feedrate in master branch

If anyone wants to try statetags on top of current master
andypugh/statetags-200328

github.com/LinuxCNC/linuxcnc/tree/andypugh/statetags-200328

The following user(s) said Thank You: rodw

Please Log in or Create an account to join the conversation.

rodw
Topic Author
Offline
Platinum Member

28 Mar 2020 21:39 #161843 by rodw

Replied by rodw on topic New pin motion.base-feedrate in master branch

andypugh wrote:
If anyone wants to try statetags on top of current master
andypugh/statetags-200328

github.com/LinuxCNC/linuxcnc/tree/andypugh/statetags-200328

Andy, great work. If I install this on my machine, what am I looking for? Does it publish additional hal pins for the tags?
I'll give it a go later today

Please Log in or Create an account to join the conversation.

andypugh
Offline
Moderator

28 Mar 2020 23:13 #161859 by andypugh

Replied by andypugh on topic New pin motion.base-feedrate in master branch

I actually have no idea.

I _think_ that it mainly keeps the "status" stuff up to date.
I think ideally Chris' extra HAL pin would be added too. And maybe a few more.

Please Log in or Create an account to join the conversation.

cmorley
Offline
Moderator

28 Mar 2020 23:35 #161868 by cmorley

Replied by cmorley on topic New pin motion.base-feedrate in master branch

I assume that if statetags was ready it would have been merged long ago.
So updating statetags to master branch is great -(and you probably should just merge it into linuxcnc's branch of statetags), it means someone needs to work on it till it works - it's a big change - i don't understand it and the people that do are not working on linuxcnc.

Also ya do we know the scope functionality of state tags?
It's been vaguely talked about for so long i don't know anymore.

My attempt was to fix a small problem so i could try to understand a bit about what i was doing, but I agree statetags is the goal - I personally just can't make that jump, i'm not that good to just look at small bits of the code and know what it is doing or if it is wrong code.

If it was completely up to me, i think I would:
-merge my work into 2.8 so at least the feedcode works for people in the next release.
- release 2.8 so people have a functional up to date version.

- start merging the unstable things like statetags and work on it - slightly broken master is a good motivator (obviously we are trying to avoid long breaks)

but at this point I can't even get people to answer the maillist for how to release so we are in pretty bad shape.
People are working on linuxcnc (I see Dewey commiting interesting things for instance) but there is no forward movement in this project as a whole.

Eventually I'll just do what I think is best at the moment and if people don;t like it they can come take this lead

The following user(s) said Thank You: phillc54, tommylight, Clive S, rodw, thefabricator03

Please Log in or Create an account to join the conversation.

phillc54
Offline
Moderator

28 Mar 2020 23:52 #161874 by phillc54

Replied by phillc54 on topic New pin motion.base-feedrate in master branch

If it was completely up to me, i think I would:
-merge my work into 2.8 so at least the feedcode works for people in the next release.
- release 2.8 so people have a functional up to date version.

I agree with this.
Is there a list of things that need completion before 2.8 can be released that some of us could maybe help with.

The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540

Time to create page: 0.088 seconds