New pin motion.base-feedrate in master branch

That HAL pin must be requested-vel?
Does your HAL pin suffer from the not-synched-to-motion problem?
Maybe it's not much of a problem usually.. only comes up if you change the feedrate in the program - status shows the last feed code in the program as soon as the interpreter reads that far ahead.

Chris

cmorley wrote: That HAL pin must be requested-vel?
Does your HAL pin suffer from the not-synched-to-motion problem?
Maybe it's not much of a problem usually.. only comes up if you change the feedrate in the program - status shows the last feed code in the program as soon as the interpreter reads that far ahead.

It is the hal pin of a gladevcp spinbutton that is set by the user or from a file of materials.

So Phill, do we only need this for cornerlock? Thats my understanding. I just wondered if you used it for anything else.

I had a bit of a play swappiing some pins around but did not see the cornerlock ever cut in even without me changing anything. But it should have. Does it need to be cutting for it to kick in? I was only dry cutting.

Also, what was the purpose of the pin plasmac.requested_velocity? I could not see it was used.

Chris, leave it as it is in device units per minute. I assume you meant inches per minute, not feet per minute. It seems internally the Plasmac component converts velocities per second to device units per minute.

I have ventured into state tags for a look. I don't think its terribly hard, just lots of it becasue the tags structure need updating at every point a message is sent. So its lots of cut and paste. But everybody ran scared when they saw how many changes in the commits with out looking at what they are. Also, you could cheat and write new task and io modules so they could be deployed without breaking anything. I was able to copy a couple of folders and update the make files in about 30 minutes to create my own task and io modules (which were exact copies of milltask and io modules) but heck it all compiled with master branch.

rodw wrote: So Phill, do we only need this for cornerlock? Thats my understanding. I just wondered if you used it for anything else.

Cornerlock only from memory.

I had a bit of a play swappiing some pins around but did not see the cornerlock ever cut in even without me changing anything. But it should have. Does it need to be cutting for it to kick in? I was only dry cutting.

I think you need Arc OK plus THC Active

Also, what was the purpose of the pin plasmac.requested_velocity? I could not see it was used.

I must have left that in after i ripped out the remap junk, I am sure it is not used.

So by using fcode pin you could have different feedrate in the program and wouldn't need to adjust the gui spinbutton at the right moment.

The nice thing here is if we do get statetags we could just rip out my new NML message and add the HAL pin to the new statetag code (I assume anyways)

I'll wait to see if any other developers comment on the code and if all good, i'll clean it up a merge it in a few days. The pin name will change.

Thanks Rod for testing!

Chris

phillc54 wrote:

Also, what was the purpose of the pin plasmac.requested_velocity? I could not see it was used.

I must have left that in after i ripped out the remap junk, I am sure it is not used.

Its used in some calculations but only in the absence of a cutting velocity so it has no effect. I might have a look at using that pin and changing the corner lock code to just use requested velocity and see how it goes.