New pin motion.base-feedrate in master branch

More
6 years 7 months ago #161404 by cmorley
Thanks I'll fix that right away :)

Chris

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161405 by cmorley
I ended up with:
Code:
void SET_FEED_RATE(double rate) { // send a code status NML message with the F word setting send_code_status_msg(rate); if(canon.feed_mode) { START_SPEED_FEED_SYNCH(canon.spindle_num, rate, 1); canon.linearFeedRate = rate; } else { /* convert from /min to /sec */ rate /= 60.0; /* convert to traj units (mm & deg) if needed */ double newLinearFeedRate = FROM_PROG_LEN(rate), newAngularFeedRate = FROM_PROG_ANG(rate); if(newLinearFeedRate != canon.linearFeedRate || newAngularFeedRate != canon.angularFeedRate) flush_segments(); canon.linearFeedRate = newLinearFeedRate; canon.angularFeedRate = newAngularFeedRate; } }

Which seemed to work the same.
Pushed to the testing branch.

Thanks for the fast code review!

Chris

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161413 by fixer
Great, thank you! I applied changes to 2.7 and it also works there.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161470 by fixer
Chris,

Could you add feed per revolution value to this pin when in spindle synchronized motion (G33, G76)?

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago - 6 years 7 months ago #161543 by cmorley
Pushed an enhancement for this - please let me know if it's working for you

Chris
Last edit: 6 years 7 months ago by cmorley.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161573 by fixer
Works for me, exactly what I had in mind!
Thank you!

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.132 seconds
Powered by Kunena Forum