Forum Menu

New pin motion.base-feedrate in master branch

More
6 years 7 months ago #161374 by phillc54
Replied by phillc54 on topic New pin motion.base-feedrate in master branch

So this pin will avoid the kludge of the hal pin and allow gcode to be written normally. But managing the materials is still required. I think I have over 80 materials defined for my machine based on the manufacturer's cut charts.

As far as PlasmaC is concerned I need to think a lot more about this but at the moment I cannot see any advantage for PlasmaC to use this new pin.
I can definitely see an advantage for plasma users that don't use PlasmaC.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161375 by rodw
Replied by rodw on topic New pin motion.base-feedrate in master branch

phillc54 wrote:

So this pin will avoid the kludge of the hal pin and allow gcode to be written normally. But managing the materials is still required. I think I have over 80 materials defined for my machine based on the manufacturer's cut charts.

As far as PlasmaC is concerned I need to think a lot more about this but at the moment I cannot see any advantage for PlasmaC to use this new pin.
I can definitely see an advantage for plasma users that don't use PlasmaC.


Probably correct. But it won't break anything and will allow any user to program their own feed rates. That would result in a more robust system and possibly one less support vector. If you set the feedrate using the Plasmac feedrate pin, this pin is updated. So once the pin exists, I think for the sake of a 60 second edit in the code, it would be worth using.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161376 by phillc54
Replied by phillc54 on topic New pin motion.base-feedrate in master branch
As I said, I need to think a lot more about it. It works OK as is so there is no need to rush.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161400 by fixer
Replied by fixer on topic New pin motion.base-feedrate in master branch
Cmorley, thank you!
This is great addition, even for milling and turning. It should be possible to show real feed value on user interface now.
It does, however only work with G94. With G93 and G95 it reports 0.0.

rtapi_print( "SET_Fcode status: %f\n", emcmotCommand->fcode) executes only when G94 is called. Do you think you could fix for G95 to show correctly?

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161401 by cmorley
Replied by cmorley on topic New pin motion.base-feedrate in master branch
I'll look into it.
Thanks for testing

Chris

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago - 6 years 7 months ago #161403 by fixer
Replied by fixer on topic New pin motion.base-feedrate in master branch
Already found it, here in emccanon.cc:
Code:
void SET_FEED_RATE(double rate) { if(feed_mode) { START_SPEED_FEED_SYNCH(rate, 1); currentLinearFeedRate = rate; send_code_status_msg(rate); //G95 } else { /* convert from /min to /sec */ rate /= 60.0; /* convert to traj units (mm & deg) if needed */ double newLinearFeedRate = FROM_PROG_LEN(rate), newAngularFeedRate = FROM_PROG_ANG(rate); if(newLinearFeedRate != currentLinearFeedRate || newAngularFeedRate != currentAngularFeedRate) flush_segments(); currentLinearFeedRate = newLinearFeedRate; currentAngularFeedRate = newAngularFeedRate; send_code_status_msg(rate*60.0); //G94 } }
Last edit: 6 years 7 months ago by fixer.

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.079 seconds
Powered by Kunena Forum