New pin motion.base-feedrate in master branch

More
6 years 7 months ago #161924 by cmorley
Code:
Interp::write_state_tag(block_pointer block, setup_pointer settings, StateTag &state)
block is one line of gcode
settings is the current interpreter settings
Statetag is new but obviously must be the current gcode state

Chris

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161948 by rodw

cmorley wrote:

Code:
Interp::write_state_tag(block_pointer block, setup_pointer settings, StateTag &state)
block is one line of gcode
settings is the current interpreter settings
Statetag is new but obviously must be the current gcode state

Chris


Yes the StateTag structure is added to the emcmot_hal_data structure
So Chris if you have a look at motion.c Line 335, there is a procedure called init_hal_io that defines the motion pins. I'm sure you know this :)

Something like this should find the feed rate
Code:
emcmot_hal_data->tag->fields[GM_FIELD_FLOAT_FEED] // array index [1]
See: github.com/LinuxCNC/linuxcnc/blob/andypu...c/motion/state_tag.h

And finally, a definition of what State tags does in that file
Code:
/** * Tag structure that is added to a motion segment so that motion has a copy of * the relevant interp state. * * Previously, this information was stored only in the interpreter, and as * vectors of g codes, m codes, and settings. Considering that the write_XXX * and gen_XXX functions had to jump through hoops to translate from a settings * struct, the extra packing here isn't much more complex to deal with, and * will cost much less space when copying back and forth. */


So let me know when you have a feed rate pin using State tags :)

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161954 by phillc54
I think the runtest fails should be fixed before getting too far ahead, they obviously indicate a problem/problems somewhere.

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #161958 by rodw

phillc54 wrote: I think the runtest fails should be fixed before getting too far ahead, they obviously indicate a problem/problems somewhere.


Seems Issues $134, #177 and #283 refer. I think Andy is on the job as #283 was committed 19 hours ago to the official state-tags branch. The notes in the first test says it will be fixed by release of State tags and referred to #134. Talk about going around in circles for years!

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #162043 by cmorley
Well I tried a rverse-feedcode-2.8 mix branch and it seems to have worked ok.
I's like to discuss if that's a tolerable idea - but I think Andy is the only other developer to talk to about this ...
usually I would discuss this on the mail list (where it should be).

Chris
The following user(s) said Thank You: rodw

Please Log in or Create an account to join the conversation.

More
6 years 7 months ago #162163 by andypugh
Lets take it to the dev list. Perhaps Zultron will chip in?
The following user(s) said Thank You: rodw

Please Log in or Create an account to join the conversation.

Moderators: snowgoer540
Time to create page: 0.424 seconds
Powered by Kunena Forum