qtdragon - probing issues

Chris, thanks a lot for this! very nice work... Surely we have the bugs pretty well squashed now!
Did you update the type on the external offsets too (from another thread)?

Yes fixed up the external offsets stuff too.
Surely there will be some more little things along the way.
Thanks for testing and the feedback.

andypugh wrote:

cmorley wrote:

If you are asking does it automatically set g20/g21 based on machine units before probing.
I don't think it does - which does seem a bad idea.
Which behaviour do you think is a bad idea? It isn't entirely clear from the way you wrote this. 
 

I just pushed code that uses m70/72 to record/reset the motion modes before/after probing.
Seems to work fine - though I haven't tested it much.

and it's Saturday morning, the 13th, and the changes are already in Seb's debs.
I will update my little mill and check 'en out.
thanks

Chris,
well, updated.  testing
a couple of small things.
for the 'Outside Boss'  (center pick on the Outside page)  the X Neg and X Pos results are backwards, as are the Y Neg and Ypos.
I think the assignments in probe_routine.py (line 658, etc) are backwards.  see the image attached.

also the move from the -x probe completion over to the +x probe is too big.

        # move X+ 2 * (edge_length + xy_clearance)      
        aa = 2 * (self.data_side_edge_length + self.data_xy_clearance)
        s = """G91
        G1 F%s X%f

aa = 2*(1.5 +.3) =.6
it should be the -x radius just determined (xpres) + edge_length + xy_clearance
aa= 1.2174 + 1.5 +.3 == 3.0174

remember going out it moved (edge_length + xy clearance) = 1.5 +.3 = 1.8
so essentially ya just go back to the center and then out the same as the first out.

and the same goes for the Y probing.
Just my opinion.
The inside-pocket works fine.....
 

Thanks for testing.
Sounds like the similar problem with hole probing.
maybe this (have to account for latch return distance that is already moved:
(2 *self.data_side_edge_length) + latch_return + self.data_xy_clearance)

I'll look at those result calculations.