Advanced Search

Anything in a pull request should be mature and thoroughly tested. Changing the code of a hal component after it has been released brings the unpleasant possibility of breaking configurations.
A recent example is the 'toggle2nist.comp' that showed buggy behavior.
Given the lack of personnel we must not expect others to check the code we submit for inclusion.

Thank you! Will try it out on friday.

This is my crude explanation
youtube.com/shorts/nY0A_utbBd4?si=7yU3tGuBq7IW74BQ
 

blazini36 wrote:

Well anyone can just submit a component via pull request to the linuxcnc repo. Not sure if the maintainers test them at all other than making sure they compile. If it's a good an useful component, there's really no reason not to just submit it via pull request.

This is how it should be done. Chances are it would be approved because a broken component will not break Linuxcnc. Compilation is automatically tested with the commit. I have submitted one this way. It does add some overhead to what you have to do as you need to format the comments etc so the man page is generated.

This thread maybe should be helping people to get this formatted and into the code.

The wider part(base) is on right in linuxcnc as in the pic. It should be on the left the wider part is supposed to be held in the spindle. My spindle is on the left 

It's supposed to machine the head first and move down to the base. But it's flipped around. I'll try and take a video of it, 

I m not sure, I haven't gotten as far as an index yet, I'm trying to get the A and B working right first. That uses the PRUencoder. The encoder only supports quadratic at the moment. I have the A and B pulses going to the WHA and WHB inputs from the MPG(by passing the opticouplers). I'm not sure if the index pin will have to be bypassed also.

Don’t make that assumption re feedhold. And tapping. The planner is taking things direct from the Hal pin. Not from the lcnc motmod module.

it needs to be explicitly tested. Unless someone has done so already and can confirm what the behaviour is.