Sheetcam and trying to generate spotting gcode.
- beefy
- Offline
- Elite Member
Less
More
- Posts: 224
- Thank you received: 56
26 Apr 2021 03:35 #207067
by beefy
Sheetcam and trying to generate spotting gcode. was created by beefy
Just letting anyone know I've started a thread over on the Sheetcam forum as I'm having problems with Sheetcam generating the correct gcode for spotting.
forum.sheetcam.com/viewtopic.php?f=2&t=8568
It's probably something I'm doing wrong.
Keith
forum.sheetcam.com/viewtopic.php?f=2&t=8568
It's probably something I'm doing wrong.
Keith
Please Log in or Create an account to join the conversation.
- rodw
- Offline
- Platinum Member
Less
More
- Posts: 10737
- Thank you received: 3541
26 Apr 2021 07:09 #207081
by rodw
Replied by rodw on topic Sheetcam and trying to generate spotting gcode.
I don't think there is a bug
Are you using this post?
forum.linuxcnc.org/plasmac/38438-plasmac-post-processors
I've been doing this since pre-plasmac and just had to change the tool name to Centre Spot
I create a layer and move all holes to that layer and apply a drill operation using that tool.
You also need to make sure the holes are < the minimum hole diameter set in the drill operation.
Are you using this post?
forum.linuxcnc.org/plasmac/38438-plasmac-post-processors
I've been doing this since pre-plasmac and just had to change the tool name to Centre Spot
I create a layer and move all holes to that layer and apply a drill operation using that tool.
You also need to make sure the holes are < the minimum hole diameter set in the drill operation.
Please Log in or Create an account to join the conversation.
- beefy
- Offline
- Elite Member
Less
More
- Posts: 224
- Thank you received: 56
26 Apr 2021 07:13 #207082
by beefy
Replied by beefy on topic Sheetcam and trying to generate spotting gcode.
Cheers Rod,
Yep did all that, I'll check that post you linked to.
Keith
Yep did all that, I'll check that post you linked to.
Keith
Please Log in or Create an account to join the conversation.
- beefy
- Offline
- Elite Member
Less
More
- Posts: 224
- Thank you received: 56
26 Apr 2021 07:31 - 26 Apr 2021 07:38 #207083
by beefy
Replied by beefy on topic Sheetcam and trying to generate spotting gcode.
That's where I originally got the post Rod.
Just downloaded it again and re-imported into Sheetcam. Same result.
See what I said in my 2nd post in the Sheetcam forum. The issue appears to be coming from the fact the same tool is being used in the DRILL operation and the PLASMA operation. In the post code, it's the OnNewTool() function that does the checks to see if spotting is being done. It's as though this function is only running once because there is only one tool being used.
When I copied that tool, giving it a new number in the process, and using it in the PLASMA operation, not doubt "function OnNewTool()" is being run again in the post, thus turning off the spotting functionality.
Maybe try in your Sheetcam using the same tool for the DRILLING and the PLASMA operations, and see what happens. Maybe you have always had different tools for those operations.
Of course using different tools appears to make everything work great, but I'm wondering is the better and more foolproof solution is to have the post modified. I noticed there's no function in the post "OnNewOperation()" so when we have more than one operation in Sheetcam, do we need to be getting some checks done in that function. I mentioned this to Les on the Sheetcam forum.
Keith
Just downloaded it again and re-imported into Sheetcam. Same result.
See what I said in my 2nd post in the Sheetcam forum. The issue appears to be coming from the fact the same tool is being used in the DRILL operation and the PLASMA operation. In the post code, it's the OnNewTool() function that does the checks to see if spotting is being done. It's as though this function is only running once because there is only one tool being used.
When I copied that tool, giving it a new number in the process, and using it in the PLASMA operation, not doubt "function OnNewTool()" is being run again in the post, thus turning off the spotting functionality.
Maybe try in your Sheetcam using the same tool for the DRILLING and the PLASMA operations, and see what happens. Maybe you have always had different tools for those operations.
Of course using different tools appears to make everything work great, but I'm wondering is the better and more foolproof solution is to have the post modified. I noticed there's no function in the post "OnNewOperation()" so when we have more than one operation in Sheetcam, do we need to be getting some checks done in that function. I mentioned this to Les on the Sheetcam forum.
Keith
Last edit: 26 Apr 2021 07:38 by beefy.
Please Log in or Create an account to join the conversation.
- phillc54
- Offline
- Platinum Member
Less
More
- Posts: 5698
- Thank you received: 2081
26 Apr 2021 10:11 - 26 Apr 2021 10:45 #207092
by phillc54
Replied by phillc54 on topic Sheetcam and trying to generate spotting gcode.
I am away for a couple of days and only have my phone so it is difficult to follow the code...
It may well be that OnDrill() should set Spotting to 1 at the beginning and reset it at the end rather than testing if it is 1.
It may well be that OnDrill() should set Spotting to 1 at the beginning and reset it at the end rather than testing if it is 1.
Last edit: 26 Apr 2021 10:45 by phillc54. Reason: Typo
Please Log in or Create an account to join the conversation.
- beefy
- Offline
- Elite Member
Less
More
- Posts: 224
- Thank you received: 56
26 Apr 2021 10:54 #207095
by beefy
Replied by beefy on topic Sheetcam and trying to generate spotting gcode.
No problem at all Phill, I mainly posted here so anyone interested can view the Sheetcam forum where I started a thread on this.
This is nothing urgent at all, and I can easily get around the issue by ensuring a different tool is used in any drill operations and plasma operations.
In a nutshell it appears to be that if the tool is the same, then the OnNewTool() function does not run for the subsequent plasma operation, and so the post stays in "spotting mode".
I'm basically waiting to see if Les has a suggested modification to the post to prevent this happening.
Keith
This is nothing urgent at all, and I can easily get around the issue by ensuring a different tool is used in any drill operations and plasma operations.
In a nutshell it appears to be that if the tool is the same, then the OnNewTool() function does not run for the subsequent plasma operation, and so the post stays in "spotting mode".
I'm basically waiting to see if Les has a suggested modification to the post to prevent this happening.
Keith
Please Log in or Create an account to join the conversation.
- phillc54
- Offline
- Platinum Member
Less
More
- Posts: 5698
- Thank you received: 2081
26 Apr 2021 10:57 #207096
by phillc54
Replied by phillc54 on topic Sheetcam and trying to generate spotting gcode.
My other thought is that maybe onDrill doesn't even need to test for spotting at all because it is spotting
Please Log in or Create an account to join the conversation.
- rodw
- Offline
- Platinum Member
Less
More
- Posts: 10737
- Thank you received: 3541
26 Apr 2021 11:12 #207099
by rodw
Replied by rodw on topic Sheetcam and trying to generate spotting gcode.
I don't think Les can offer an opinion on a 3rd party post processor he did not write.
I think the current performance is expected behaviour becasue when we load our centre spot tool, we are actually changing the spindle as well as the tool. The spotting tool is never designed to do anything other than spotting.
I think the current performance is expected behaviour becasue when we load our centre spot tool, we are actually changing the spindle as well as the tool. The spotting tool is never designed to do anything other than spotting.
Please Log in or Create an account to join the conversation.
- AgentWD40
- Offline
- Platinum Member
Less
More
- Posts: 334
- Thank you received: 92
26 Apr 2021 15:20 - 26 Apr 2021 16:16 #207127
by AgentWD40
Replied by AgentWD40 on topic Sheetcam and trying to generate spotting gcode.
I can confirm the the issue found by beefy.
Given the criteria for a spotting operation
I also agree with beefy. I don't think a user should be required to change their tool when they can simply click a drill operation. It's not intuitive or expected that one should be *required* to change tools.
The code above says you should be be able to do it either way, but effectively you have to change your tool to ensure the expected operations are executed.
[ EDIT ]
After reviewing the rest of the pp in context it seems that as it's currently designed a tool change should be required for a spotting operation and I don't see a quick way around that. We should find a way to make that crystal clear to the users.
To avoid this behavior I wonder if the OnNewOperation() event can be utilized?
Given the criteria for a spotting operation
elseif string.match (toolName, 'Centre Spot') or
string.match (toolName, 'Center Spot') or
string.match(operationClass, 'DrillOperation') then
I also agree with beefy. I don't think a user should be required to change their tool when they can simply click a drill operation. It's not intuitive or expected that one should be *required* to change tools.
The code above says you should be be able to do it either way, but effectively you have to change your tool to ensure the expected operations are executed.
[ EDIT ]
After reviewing the rest of the pp in context it seems that as it's currently designed a tool change should be required for a spotting operation and I don't see a quick way around that. We should find a way to make that crystal clear to the users.
To avoid this behavior I wonder if the OnNewOperation() event can be utilized?
Last edit: 26 Apr 2021 16:16 by AgentWD40.
Please Log in or Create an account to join the conversation.
- AgentWD40
- Offline
- Platinum Member
Less
More
- Posts: 334
- Thank you received: 92
26 Apr 2021 16:39 - 26 Apr 2021 18:24 #207139
by AgentWD40
Replied by AgentWD40 on topic Sheetcam and trying to generate spotting gcode.
For what it's worth this example workaround seems to work at first glance. I haven't taken scribing into consideration.
The three variables used to determine cut, scribe, or spot are toolName, toolClass, and operationClass. Unfortunately the current toolName and toolClass aren't available to the OnNewOperation() event.
I'm starting to wonder if it might be best to just ignore drill operations all together and force the user to explicitly select a spotting tool to guarantee expected behavior.
function OnNewOperation()
if string.match(operationClass, 'JetOperation') then
cutType = 'Cutting'
cutName = 'cut'
spindleNum = 0
toolNum = 0
end
end
The three variables used to determine cut, scribe, or spot are toolName, toolClass, and operationClass. Unfortunately the current toolName and toolClass aren't available to the OnNewOperation() event.
I'm starting to wonder if it might be best to just ignore drill operations all together and force the user to explicitly select a spotting tool to guarantee expected behavior.
Last edit: 26 Apr 2021 18:24 by AgentWD40.
Please Log in or Create an account to join the conversation.
Moderators: snowgoer540
Time to create page: 0.078 seconds