- Posts: 7368
- Thank you received: 2181
Error in tool_offsetview.py
- cmorley
- Offline
- Moderator
-
Less
More
2 years 5 months ago #300889
by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
Pushed to master. Thank you.
Did you notice the EditorBase has one more property?
qproperty-styleColorCursor: white;
As for my qtdragon_mpg experiment - I added a way to pre-select the probe routine and only actually run it when the cycle start button is pressed.
Same thing with the MDI entry line; in MDI mode if the MDI widget has a red outline (focus selected) then cycle start will run the command.
The focus selection maybe should cancel when the modes are changed or the 'MPG Scroll' button is not checked.
i would like to get to the point that the machine doesn't move unless cycle start is pressed.
Just not sure if enough people will like it that way.
Could make it settings selectable.
Chris
Did you notice the EditorBase has one more property?
qproperty-styleColorCursor: white;
As for my qtdragon_mpg experiment - I added a way to pre-select the probe routine and only actually run it when the cycle start button is pressed.
Same thing with the MDI entry line; in MDI mode if the MDI widget has a red outline (focus selected) then cycle start will run the command.
The focus selection maybe should cancel when the modes are changed or the 'MPG Scroll' button is not checked.
i would like to get to the point that the machine doesn't move unless cycle start is pressed.
Just not sure if enough people will like it that way.
Could make it settings selectable.
Chris
Please Log in or Create an account to join the conversation.
- MarkoPolo
- Offline
- Elite Member
-
Less
More
- Posts: 319
- Thank you received: 90
2 years 5 months ago #300981
by MarkoPolo
Replied by MarkoPolo on topic Error in tool_offsetview.py
qproperty-styleColorCursor: white;
Yes, I saw this in one of the threads. You did it for someone, but it's good that you remind us of it. I will use this next time I update the theme.
I see you did it qtaxis. I don't feel comfortable testing this without real MPG. I think that the option to choose in the settings would be best, so that it would be unnoticeable to people who do not use MPG.
Quite often I put a lot of dots in the file name, qtdragon does not want to open such files, can something be done about it?
(Axis opens such files normally)
Yes, I saw this in one of the threads. You did it for someone, but it's good that you remind us of it. I will use this next time I update the theme.
I see you did it qtaxis. I don't feel comfortable testing this without real MPG. I think that the option to choose in the settings would be best, so that it would be unnoticeable to people who do not use MPG.
Quite often I put a lot of dots in the file name, qtdragon does not want to open such files, can something be done about it?
(Axis opens such files normally)
Please Log in or Create an account to join the conversation.
- cmorley
- Offline
- Moderator
-
Less
More
- Posts: 7368
- Thank you received: 2181
2 years 5 months ago #300982
by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
QtAxis uses selectable MPG scrolling but not cycle start selection.
I guess if the user didn't want it, they could change the user selection color to white or light gray, so it not noticeable. I'm not sure many people use QtAxis.
Here is the pull request for multiple periods removal:
github.com/LinuxCNC/linuxcnc/pull/1082
I see I never got an answer why multiple periods caused crashes.
I guess if the user didn't want it, they could change the user selection color to white or light gray, so it not noticeable. I'm not sure many people use QtAxis.
Here is the pull request for multiple periods removal:
github.com/LinuxCNC/linuxcnc/pull/1082
I see I never got an answer why multiple periods caused crashes.
Please Log in or Create an account to join the conversation.
- MarkoPolo
- Offline
- Elite Member
-
Less
More
- Posts: 319
- Thank you received: 90
2 years 5 months ago - 2 years 5 months ago #301015
by MarkoPolo
Replied by MarkoPolo on topic Error in tool_offsetview.py
Regarding the dots problem.
I changed the dot limit to 10 in qt_action.py
"if os.path.basename(fname).count('.') > 10:"
Also in qtdragon_handler.py
" if os.path.basename(filename).count('.') > 10:" , and everything works normally. I haven't noticed any negative effects so far.
It is possible that such restrictions are no longer necessary.
(on Debian 12 it was enough to change only the handler file)
edition
(I tested something wrong, changing the qt_action.py file on Debian 12 is also necessary)
I changed the dot limit to 10 in qt_action.py
"if os.path.basename(fname).count('.') > 10:"
Also in qtdragon_handler.py
" if os.path.basename(filename).count('.') > 10:" , and everything works normally. I haven't noticed any negative effects so far.
It is possible that such restrictions are no longer necessary.
(on Debian 12 it was enough to change only the handler file)
edition
(I tested something wrong, changing the qt_action.py file on Debian 12 is also necessary)
Last edit: 2 years 5 months ago by MarkoPolo.
Please Log in or Create an account to join the conversation.
- cmorley
- Offline
- Moderator
-
Less
More
- Posts: 7368
- Thank you received: 2181
2 years 5 months ago #301131
by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
I think I understand the original problem, fixed it and removed the restriction.
It can be reinstated with an INI switch if wanted.
Pushed to master.
It can be reinstated with an INI switch if wanted.
Pushed to master.
The following user(s) said Thank You: tommylight, MarkoPolo
Please Log in or Create an account to join the conversation.
- MarkoPolo
- Offline
- Elite Member
-
Less
More
- Posts: 319
- Thank you received: 90
2 years 5 months ago #301157
by MarkoPolo
Replied by MarkoPolo on topic Error in tool_offsetview.py
Another thing that seems to make no sense is the limitation of previewing to files that are 20MB in size. (In axis there is no limit)
To load my file, I doubled the file size in glcanon.py, like this: " self.max_file_size = min(system_memory_gb, 20) * 1024 * 1024 * 2".
The file loading time with and without preview is identical. There is no difference in moving, rotating or enlarging the preview.
To load my file, I doubled the file size in glcanon.py, like this: " self.max_file_size = min(system_memory_gb, 20) * 1024 * 1024 * 2".
The file loading time with and without preview is identical. There is no difference in moving, rotating or enlarging the preview.
Please Log in or Create an account to join the conversation.
Moderators: cmorley
Time to create page: 0.619 seconds