Error in tool_offsetview.py

More
30 Mar 2022 02:21 #238685 by MarkoPolo
I fixed the problem with the "rapid override" value, and a little visual fixes, it should work fine.
Attachments:
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
06 Apr 2022 22:05 #239476 by MarkoPolo
Thanks for the very good changes with the buttons to be disabled. I would also add "MAN" and "MDI" buttons to the list.

I'm sending files with minor changes to better fit and fixing a big bug with incorrect display of "rapid override" values when moving the "feedrate" slider
Attachments:

Please Log in or Create an account to join the conversation.

More
07 Apr 2022 00:37 #239488 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
man and mdi should alreafy disable when running - It fixed the action button to do this.
the feedrate bug should be fixed too.

I'll look at your changes soon. thanks

Please Log in or Create an account to join the conversation.

More
09 Apr 2022 18:25 #239763 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
I took a quick look at your .ui file changes.
master branch as moved since your changes so just uploading it is not possible.
The .ui file is the hardest to hand edit changes into.
using git/patches makes it easier for me to incorporate.

i also noted that some of the image file paths were switched away from the resource file based paths to relative paths.

I did add your style changes to master.
Thank you for your code changes.

Chris

Please Log in or Create an account to join the conversation.

More
10 Apr 2022 19:12 - 10 Apr 2022 19:13 #239843 by MarkoPolo
I've never used git / path. How to use it to make it easier to make changes?

Which image file paths have been changed?
Which line numbers have an error?
It is possible that I am doing something wrong, I would like to avoid such mistakes.

After the last update, qtdragon does not start, and so does qtdragon_hd.


As for qtdragon_hd.ui, I see a lot of flaws, I don't use qtdragon_hd but I will be happy to work on it. 
Attachments:
Last edit: 10 Apr 2022 19:13 by MarkoPolo.

Please Log in or Create an account to join the conversation.

More
10 Apr 2022 23:42 #239869 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
After checking manually I agree ..I can't find any image file not using the resource file.
I did a diff check of your file vrs the latest file at the time and it seemed to show image path changes. weird.

Development in linuxcnc is usually done by compiling the source code which is held on github.
After that you can do 'pull requests' of new work or send patches made from different branches or i can look at your code on github.

Normally posting the changed files here is fine, it's just ui files are tricky to edit.

I'm happy to get improvements on any screen you are willing to work on.


I think I have fixed the error you found - it may take a bit for the buildbot to update.

Chris
The following user(s) said Thank You: tommylight

Please Log in or Create an account to join the conversation.

More
12 Apr 2022 22:30 #240091 by MarkoPolo
Fixed a lot of bad match bugs in qtdragon_hd. I can't use pull request yet and it's traditional for now. I have modified the latest qtdragon_hd.ui file. so it is possible that it is enough to replace the whole file if you accept these changes.


qtdragon is now working properly, ngcgui is starting (I don't know what's going on yet, but it's a detail), the buttons that are supposed to turn off during work also work fine. Thanks.
Attachments:

Please Log in or Create an account to join the conversation.

More
13 Apr 2022 01:18 #240103 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
Done. Thank you for fixes.

Chris

Please Log in or Create an account to join the conversation.

More
13 Apr 2022 17:49 #240168 by MarkoPolo
There are two more icons modified ...
What's the next step, colored messages on the bottom bar?

Please Log in or Create an account to join the conversation.

More
14 Apr 2022 01:39 #240201 by cmorley
Replied by cmorley on topic Error in tool_offsetview.py
I saw the icons but didn't relize they were different. What was different?

Please Log in or Create an account to join the conversation.

Moderators: cmorley
Time to create page: 0.104 seconds
Powered by Kunena Forum